From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 49F60201 for ; Sun, 14 Oct 2018 22:47:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A249B211B7; Sun, 14 Oct 2018 16:47:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 14 Oct 2018 16:47:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=qlnrf6giNP RFHd6sY9GfeIX2RCkc0lCLqYSLv1/iZEI=; b=kYtXw3MGduM022IAYcHv5KGFtz Rha+mej7k8PGYnDtrqnkssDOkXxXGo5nDE7dL/ALSBDUs2KR/F74yuTs+Bc6Svtn EmFvL2L+AFAQQfJhA/342Uu3Nn2FogBo516BHrk+joGQOiie7YCcQt8NcvCv5vdW VD7FTmM5evyLP2ud0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=qlnrf6giNPRFHd6sY9GfeIX2RCkc0lCLqYSLv1/iZEI=; b=ihFjqwck 6ihcDrGkSM55AhUtPFo9WWUt7oAi6WXNwRpAmFwbPUU4pgysPxhYRvBJr245qInq fDyYySH+8zgClsZRizIgOb3tzI2AoB6kBsKM1X7aRp1lC8MAz8izFt4c4WFkIp5S z5B3I++XiQxv3IBMxzC5deKu9dtjoae9TYnEaEu3pAqEsDwBPtu9/qMGG2GLXIp5 wGIccj4ep+mf6Rnp4yTAtwjvd413ZYXmYlPWvk1Vp33VOj2RJckdpZ6j4/rDKaMp l9V8Bphxg22y8GwRp9uigP0FIJye53XzJPcLdDv5KDfC/VfRGzzthJR0PEjJ9wFe BwhxwHYJZo+mhw== X-ME-Sender: X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 94F37E40E6; Sun, 14 Oct 2018 16:47:50 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com Date: Sun, 14 Oct 2018 22:47:41 +0200 Message-Id: <20181014204747.26621-2-thomas@monjalon.net> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181014204747.26621-1-thomas@monjalon.net> References: <20180907230958.21402-1-thomas@monjalon.net> <20181014204747.26621-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v5 1/7] net/mlx5: remove useless driver name comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2018 20:47:52 -0000 The function mlx5_dev_to_port_id() is returning all the ports associated to a rte_device. It was comparing driver names while already comparing rte_device pointers. If two devices are the same, they will have the same driver. So the useless driver name comparison is removed. Signed-off-by: Thomas Monjalon --- drivers/net/mlx5/mlx5_ethdev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 61eda537b..cacdf8e18 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -1305,10 +1305,7 @@ mlx5_dev_to_port_id(const struct rte_device *dev, uint16_t *port_list, RTE_ETH_FOREACH_DEV(id) { struct rte_eth_dev *ldev = &rte_eth_devices[id]; - if (!ldev->device || - !ldev->device->driver || - strcmp(ldev->device->driver->name, MLX5_DRIVER_NAME) || - ldev->device != dev) + if (ldev->device != dev) continue; if (n < port_list_n) port_list[n] = id; -- 2.19.0