[dpdk-dev] [PATCH] vfio: fix missing header inclusion

[dpdk-dev] [PATCH] vfio: fix missing header inclusion

[Jerin Jacob]

The following change set introduces HAVE_VFIO_DEV_REQ_INTERFACE
and used in the below files.

drivers/bus/pci/linux/pci_vfio.c
drivers/bus/pci/pci_common.c
lib/librte_eal/linuxapp/eal/eal_interrupts.c

However, Except the first file, the change missed to include
<rte_vfio.h> where HAVE_VFIO_DEV_REQ_INTERFACE defined.
This creates runtime following error on vfio-pci mode and
kernel >= 4.0.0 combination.

EAL: [rte_intr_enable] Unknown handle type of fd 95
EAL: [pci_vfio_enable_notifier]Fail to enable req notifier.
EAL: Fail to unregister req notifier handler.
EAL: Error setting up notifier!
EAL: Requested device 0000:07:00.1 cannot be used

Fixes: cda94419964f ("vfio: fix build with Linux < 4.0")

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 drivers/bus/pci/pci_common.c                 | 1 +
 lib/librte_eal/linuxapp/eal/eal_interrupts.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 4b3749a9a..c0238d444 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -23,6 +23,7 @@
 #include <rte_string_fns.h>
 #include <rte_common.h>
 #include <rte_devargs.h>
+#include <rte_vfio.h>
 
 #include "private.h"
 
diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
index 767b50880..39252a887 100644
--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c
+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
@@ -33,6 +33,7 @@
 #include <rte_errno.h>
 #include <rte_spinlock.h>
 #include <rte_pause.h>
+#include <rte_vfio.h>
 
 #include "eal_private.h"
 #include "eal_vfio.h"
-- 
2.19.1

Re: [dpdk-dev] [PATCH] vfio: fix missing header inclusion

[Thomas Monjalon]

17/10/2018 07:30, Jerin Jacob:
> The following change set introduces HAVE_VFIO_DEV_REQ_INTERFACE
> and used in the below files.
> 
> drivers/bus/pci/linux/pci_vfio.c
> drivers/bus/pci/pci_common.c
> lib/librte_eal/linuxapp/eal/eal_interrupts.c
> 
> However, Except the first file, the change missed to include
> <rte_vfio.h> where HAVE_VFIO_DEV_REQ_INTERFACE defined.
> This creates runtime following error on vfio-pci mode and
> kernel >= 4.0.0 combination.
> 
> EAL: [rte_intr_enable] Unknown handle type of fd 95
> EAL: [pci_vfio_enable_notifier]Fail to enable req notifier.
> EAL: Fail to unregister req notifier handler.
> EAL: Error setting up notifier!
> EAL: Requested device 0000:07:00.1 cannot be used
> 
> Fixes: cda94419964f ("vfio: fix build with Linux < 4.0")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

Applied, thanks