From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7BEDA5F62 for ; Thu, 18 Oct 2018 03:24:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D75022223A; Wed, 17 Oct 2018 21:24:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Oct 2018 21:24:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=Pl4rUM+RX6 jnE3sk2X1ie59a7VFtaCwKSPVx9iqIUTw=; b=S4gMT+NfXUQAJGB6/0FMNCUwwK rUYHWBqsMUZYCTTUR8KrEi7kXqXJRo2FmY07v/TLtwpxXTWOfh9awBLbgu+fFdWi o2AhqrrtHQhy7j5wrdCT9Q4wrjWqf0jweDVzHQ48XIS971omq4acmVUNpIByPQB+ nipxoXfeyeYT/eH8k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=Pl4rUM+RX6jnE3sk2X1ie59a7VFtaCwKSPVx9iqIUTw=; b=MhcGKqvt ykplVEJb4V8DzELEXvK62AyU9X8LqFgnEff0n5f0YEdaO3zaiX/NS4H1pyizwzBZ V9E5+UJvEzTYrmidN5obnX+4mlhrnUHbkoo0/sbzA1x9JlyoecjAn8F8qi0NfsYB vaLYU7EbDdnh7zCO62JO8HtiEMzGKl8f34LVk/uWbDniLy11Pc0+cWznLYRhwcFW a2WEvc2Ubtq183S4qMsdt4YtTOJUOpl//i/hiOyufzSXo/95lcVPq+gLDQroSkyb xFaCpyrQ/j8db4RlKqn+U6VGnzw50rQWQKJTir92+YhJJwNbAmTMnlimIZwJyDNh 6vDD3nL8hR7hnw== X-ME-Sender: X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BDACC102E9; Wed, 17 Oct 2018 21:24:06 -0400 (EDT) From: Thomas Monjalon To: ferruh.yigit@intel.com, arybchenko@solarflare.com Cc: dev@dpdk.org, ophirmu@mellanox.com, bernard.iremonger@intel.com, rahul.lakkireddy@chelsio.com Date: Thu, 18 Oct 2018 03:23:58 +0200 Message-Id: <20181018012402.1240-3-thomas@monjalon.net> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181018012402.1240-1-thomas@monjalon.net> References: <20180907233929.21950-1-thomas@monjalon.net> <20181018012402.1240-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v5 2/6] app/testpmd: allow detaching a port not closed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 01:24:08 -0000 The testpmd application aim is for testing; so order of operations should not be enforced. There was a test to forbid detaching before closing a port. However, it may interesting to test what happens in such case. It is possible for a PMD to automatically close the port when detaching. in order to avoid a crash, it is checked that the port must be stopped before detaching (as for closing). Signed-off-by: Thomas Monjalon --- app/test-pmd/testpmd.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index c4109417a..31aadec63 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2343,13 +2343,15 @@ detach_port(portid_t port_id) printf("Detaching a port...\n"); if (!port_is_closed(port_id)) { - printf("Please close port first\n"); - return; + if (ports[port_id].port_status != RTE_PORT_STOPPED) { + printf("Port not stopped\n"); + return; + } + printf("Port was not closed\n"); + if (ports[port_id].flow_list) + port_flow_flush(port_id); } - if (ports[port_id].flow_list) - port_flow_flush(port_id); - if (rte_eth_dev_detach(port_id, name)) { TESTPMD_LOG(ERR, "Failed to detach port %u\n", port_id); return; -- 2.19.0