From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 026425F4D
for <dev@dpdk.org>; Thu, 18 Oct 2018 03:35:22 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 8604F21DE0;
Wed, 17 Oct 2018 21:35:22 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Wed, 17 Oct 2018 21:35:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding; s=mesmtp; bh=n/35PxK2h9
qLbS/oPR/jxSFk3AWCqB3qojM6OWgntpM=; b=iO/KTPgDfoIxosnipA5vv0BnDo
7fXy1rWOLUpVJ5rR5SeXbh8YhCy+RQn+7VQGHSNqTINoxo369HO7pEn34OTwKow6
lW+GYQOLQ3OxxcpJxplUEBSIw/tTXOn6KbhlDbN9H7BXf3mi8/E98wye7v6ZA19G
jk5+PvfYreEBMjobU=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:date:from
:in-reply-to:message-id:mime-version:references:subject:to
:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
fm1; bh=n/35PxK2h9qLbS/oPR/jxSFk3AWCqB3qojM6OWgntpM=; b=TpNOMjKL
+I5Fx0MWL1hQeHcG20Kc6/6uz/AUs1NU6X7Q6GwmA13l1ofzv80/Z3bCmkQtbONv
z47htEqMc4b/gM3wnqOFQkMHkcMf+3IR4KkoJKyxWJJ55OiZSMNtDsB8L1SVuS1O
qxJJqYUyg/xUt/bJsXchDyxhIa+3L9d3Ip/eS8ZYMFgi0Z+YXW/lCQsmZpu8eiGu
k4fGB/t+YHx2Eda1DhKyQILY29PavffADHLor6ufkMGYFyI4qPESYpZR8mZawuyH
HS4QytNfXD0I6RBorl8vRQCsDIUZUMCF4+iTpIJOPJD5H/1Z8gwl3ZkvucUNpAVH
+TZ1NNs4gxcHhA==
X-ME-Sender: <xms:WuPHW4yRXq8dfevrlu0zN3dg3FTtJLT7hf6HqHD1n7NqbrsBV-5U3Q>
X-ME-Proxy: <xmx:WuPHW7O9JjeHw7-1Y8HvXdhiQCldh7OwGojReN3t3908eqLQeFlUPQ>
<xmx:WuPHWyRhcxIJW-i-q2FVumvYSlzsNvsjaSz-VrmPY0iBkf_d3LizVA>
<xmx:WuPHW75WjAOUWb9Pg66-IL8ZGwtG-s2I2gykmMHbGGzDvjp4fUnmog>
<xmx:WuPHW81hHJ3BgYCc4Du5qglIIu_8GyRcsR6XaMkbngXGdwKjDQvakQ>
<xmx:WuPHW4lu0RZUl0wkFs8VJwzkpNsPWkHri1toz0UVfLdgHHczlVZK4Q>
<xmx:WuPHW3wBKrKv1nkr1ob6y-026RgKuen8tJq4ot5YdGU2SXiqbodJhQ>
Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 243D1E462B;
Wed, 17 Oct 2018 21:35:21 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, wisamm@mellanox.com,
ferruh.yigit@intel.com, arybchenko@solarflare.com
Date: Thu, 18 Oct 2018 03:35:15 +0200
Message-Id: <20181018013522.11253-1-thomas@monjalon.net>
X-Mailer: git-send-email 2.19.0
In-Reply-To: <20181007222554.4886-1-thomas@monjalon.net>
References: <20181007222554.4886-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v5 0/7] replace attach/detach functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Oct 2018 01:35:23 -0000
The functions for EAL attach/detach had already some replacements,
so they are removed.
The functions for ethdev attach/detach are removed and replaced
thanks to a new ethdev iterator working with devargs.
rte_eth_dev_attach(devargs, &port_id)
is replaced by:
rte_dev_probe(devargs);
RTE_ETH_FOREACH_MATCHING_DEV(port_id, devargs, &iterator) {
do what you want with the new port_id
}
The biggest benefit is to be able to manage devargs string
matching several ports to probe.
Depends on: https://patches.dpdk.org/project/dpdk/list/?series=1964
Changes in v5:
- check double detach in testpmd
Changes in v4:
- fix compilation (due to stricter checks in v3)
Changes in v3 - after Andrew's review:
- coding rules compliance
- stricter checks for snprintf
- rte_eth_iterator_free() becomes rte_eth_iterator_cleanup()
- add rte_eth_iterator_cleanup in .map
Changes in v2 - after Andrew's review:
- return only 0 or -1 in vdev_dev_match()
- fix freeing of strings in the iterator
- add rte_eth_iterator_free()
- tolerate extra parameters from old syntax
- add more comments
- separate contributing guide patch
Thomas Monjalon (7):
bus/vdev: add iteration filter on name
ethdev: add iterator to match devargs input
ethdev: allow iterating with pure class filter
doc: replace doxygen example in contribution guide
ethdev: remove deprecated attach/detach functions
eal: remove deprecated attach/detach functions
app/testpmd: check not detaching device twice
app/test-pmd/testpmd.c | 31 ++-
doc/guides/contributing/documentation.rst | 15 +-
doc/guides/prog_guide/index.rst | 1 -
.../prog_guide/port_hotplug_framework.rst | 106 ---------
doc/guides/rel_notes/deprecation.rst | 12 -
doc/guides/rel_notes/release_18_11.rst | 14 +-
drivers/bus/vdev/vdev_params.c | 19 +-
drivers/net/virtio/virtio_user_ethdev.c | 1 -
lib/librte_eal/common/eal_common_dev.c | 53 -----
lib/librte_eal/common/include/rte_common.h | 6 +
lib/librte_eal/common/include/rte_dev.h | 27 ---
lib/librte_eal/rte_eal_version.map | 2 -
lib/librte_ethdev/Makefile | 2 +-
lib/librte_ethdev/ethdev_private.c | 10 +-
lib/librte_ethdev/ethdev_private.h | 6 +
lib/librte_ethdev/meson.build | 2 +-
lib/librte_ethdev/rte_class_eth.c | 9 +-
lib/librte_ethdev/rte_ethdev.c | 223 +++++++++++-------
lib/librte_ethdev/rte_ethdev.h | 110 ++++++---
lib/librte_ethdev/rte_ethdev_version.map | 5 +-
20 files changed, 316 insertions(+), 338 deletions(-)
delete mode 100644 doc/guides/prog_guide/port_hotplug_framework.rst
--
2.19.0