From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id B8C361B4E2
 for <dev@dpdk.org>; Fri, 19 Oct 2018 13:38:37 +0200 (CEST)
Received: from [107.15.85.130] (helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1gDDDN-0005GC-7g; Thu, 18 Oct 2018 14:40:19 -0400
Date: Fri, 19 Oct 2018 07:38:16 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Liang Ma <liang.j.ma@intel.com>
Message-ID: <20181019113815.GA30254@hmswarspite.think-freely.org>
References: <1538666296-25742-1-git-send-email-liang.j.ma@intel.com>
 <5107033.R7BcetJnk1@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5107033.R7BcetJnk1@xps>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Score: 0.3 (/)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH] devtools/check-symbol-changes.sh: awk script
 issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Oct 2018 11:38:38 -0000

On Fri, Oct 19, 2018 at 12:48:57PM +0200, Thomas Monjalon wrote:
> Hi Neil,
> 
> Are you OK with this patch?
> 
> 
> 04/10/2018 17:18, Liang Ma:
> > There is a issue inside check-symbol-changes.sh awk script.
> > When the script try to parse the section name from  patch,
> > The script put char "+" into the section name.
> > 
> > Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> > ---
> >  devtools/check-symbol-change.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> > index c0d2a6d..4a0f4d8 100755
> > --- a/devtools/check-symbol-change.sh
> > +++ b/devtools/check-symbol-change.sh
> > @@ -30,7 +30,7 @@ build_map_changes()
> >  		# the rest of the line with the + and { symbols remvoed.
> >  		# Triggering this rule sets in_sec to 1, which actives the
> >  		# symbol rule below
> > -		/^.*{/ {
> > +		/^[^-+]*{/ {
> >  			if (in_map == 1) {
> >  				sec=$(NF-1); in_sec=1;
> >  			}
> 
> 
> 
> 

I don't think so.  The section name might get a + in front of it on lines like
this:

+EXPERIMENTAL {

But the above change just skips matching on it, which I don't think is what we
want.  The right fix I think would be to match on it, then strip the leading
plus with a sed operation in the body of the match rule.

Neil