From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EFC451B200 for ; Fri, 19 Oct 2018 15:09:54 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Oct 2018 06:09:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,400,1534834800"; d="scan'208";a="82514022" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga007.jf.intel.com with ESMTP; 19 Oct 2018 06:09:52 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id w9JD9pja016650; Fri, 19 Oct 2018 14:09:51 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id w9JD9pTN029517; Fri, 19 Oct 2018 14:09:51 +0100 Received: (from lma25@localhost) by sivswdev01.ir.intel.com with LOCAL id w9JD9par029513; Fri, 19 Oct 2018 14:09:51 +0100 Date: Fri, 19 Oct 2018 14:09:51 +0100 From: "Liang, Ma" To: Neil Horman Cc: Thomas Monjalon , dev@dpdk.org Message-ID: <20181019130951.GC1349@sivswdev01.ir.intel.com> References: <1538666296-25742-1-git-send-email-liang.j.ma@intel.com> <5107033.R7BcetJnk1@xps> <20181019113815.GA30254@hmswarspite.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181019113815.GA30254@hmswarspite.think-freely.org> User-Agent: Mutt/1.4.2.3i Subject: Re: [dpdk-dev] [PATCH] devtools/check-symbol-changes.sh: awk script issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2018 13:09:55 -0000 Hi Neil, there are two things here. 1. This issue give me negative report when I run checkpatch. So, I hope we can disable symbol check before we fix it. 2. How to fix that I still don't understand why we need match section name start with '+'. The section name should start with 'A-Z' only for my opinion. Regards Liang On 19 Oct 07:38, Neil Horman wrote: > On Fri, Oct 19, 2018 at 12:48:57PM +0200, Thomas Monjalon wrote: > > Hi Neil, > > > > Are you OK with this patch? > > > > > > 04/10/2018 17:18, Liang Ma: > > > There is a issue inside check-symbol-changes.sh awk script. > > > When the script try to parse the section name from patch, > > > The script put char "+" into the section name. > > > > > > Signed-off-by: Liang Ma > > > --- > > > devtools/check-symbol-change.sh | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh > > > index c0d2a6d..4a0f4d8 100755 > > > --- a/devtools/check-symbol-change.sh > > > +++ b/devtools/check-symbol-change.sh > > > @@ -30,7 +30,7 @@ build_map_changes() > > > # the rest of the line with the + and { symbols remvoed. > > > # Triggering this rule sets in_sec to 1, which actives the > > > # symbol rule below > > > - /^.*{/ { > > > + /^[^-+]*{/ { > > > if (in_map == 1) { > > > sec=$(NF-1); in_sec=1; > > > } > > > > > > > > > > I don't think so. The section name might get a + in front of it on lines like > this: > > +EXPERIMENTAL { > > But the above change just skips matching on it, which I don't think is what we > want. The right fix I think would be to match on it, then strip the leading > plus with a sed operation in the body of the match rule. > > Neil >