From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id D935C58C4;
 Wed, 24 Oct 2018 11:34:39 +0200 (CEST)
Received: from rsa59-2-82-233-193-189.fbx.proxad.net ([82.233.193.189]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1gFFa0-0005t9-65; Wed, 24 Oct 2018 11:35:57 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
 Wed, 24 Oct 2018 11:34:36 +0200
Date: Wed, 24 Oct 2018 11:34:36 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, stable@dpdk.org
Message-ID: <20181024093436.c6ak47y6ckofyofm@platinum>
References: <20181023162454.15519-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181023162454.15519-1-thomas@monjalon.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH] kvargs: fix processing a null list
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 09:34:40 -0000

On Tue, Oct 23, 2018 at 06:24:54PM +0200, Thomas Monjalon wrote:
> In the doxygen description of rte_kvargs_process(), it is said:
> 	If *kvlist* is NULL function does nothing.
> It has been added by mistake here instead of rte_kvargs_free().
> Anyway, null list should be correctly handled in both functions.
> 
> Comments are fixed in both functions and NULL handling is added
> to rte_kvargs_process().
> 
> Fixes: c34af7424e09 ("kvargs: fix freeing behaviour for null")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

> @@ -119,11 +119,10 @@ void rte_kvargs_free(struct rte_kvargs *kvlist);
>   *
>   * For each key/value association that matches the given key, calls the
>   * handler function with the for a given arg_name passing the value on the
> - * dictionary for that key and a given extra argument. If *kvlist* is NULL
> - * function does nothing.
> + * dictionary for that key and a given extra argument.

It looks the rest of the api documentation is perfectible :)
I'll send a fix in another patch.

Thanks,
Olivier