From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 791854CC5 for ; Wed, 24 Oct 2018 22:46:12 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id j23-v6so3020667pfi.4 for ; Wed, 24 Oct 2018 13:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dkx7TAXpHCT3AdHHMQkHu6vJtoi0dd6E86/EfPfnWhI=; b=t0xGUU0PKi13eiCKLhAlbx+WpNqevWsqDPJy7gXcJf2bOEFIrgVrIj1IWYWZPvHSD4 LUJp3WOp8EyaYvFU0y9mPHOsCo0zWKPYv5w3vEaKY+0NJuHUcS5Gzd8N9VgnMr4PysdL Fx11kGDaYtaDcqjrtAlbf4ejmmSYt8cEukmCcurqRMCEA/EmJJkuZre1l4neZpy4/lGz NZCrrKQsXqQGGkKi3QB3JEfcLT0mq6D0IMzKRqS4Jq9m/TaBi29FAGd5Mde7XoahZaLl vhf/gMZYrgEiWZ/OQh/1jYqV+8mvp6PznS0q41QECCi0OQkeqI0BKcGVHyBkmaHzOCHr xypg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dkx7TAXpHCT3AdHHMQkHu6vJtoi0dd6E86/EfPfnWhI=; b=i8rHH58En5utT2aWqy4UzUWh0l2rLyg8t9vhxJbGCc8m00/rfZywuD96fgo6YDXMBQ xK6e4eBOEA1OYYEs+mfrB6+vznz63K/UHvOS1NLdDjWmNw3g5LMWvaMiOuVpYdU9jP1t LG+QA1iHNMOSWGA+rqOc9U/Y2I6tnfQhAQcTSUjo9e/9+yVSjNgkalXccNBdWLc98yxG qaGpLOokFJS6zheyVoj4ZnA8Ez4XyyvlRgJ0rIMeuFqNlWYRZblII1ScdcN12cingwYN GEk8hKh36DhNs40fBwjh74AE+lk6lXqJYYKvDXWQgC2nLQZ2hMAq7zSSdwRPsucguNc3 3IHQ== X-Gm-Message-State: AGRZ1gKXPvI77jzVRl2ICKGLKU57WiNtjb0okbmFSnyt4glXlyLKqL5v ogBRlk5BYQF1z6z600ik21Yfdg== X-Google-Smtp-Source: AJdET5ctJD8PWYew7xQGTJkF7ESFkzXcbctSpQ2liqhtfh9FRAWT24rYIDQAmNCCq28tTphu4Ls4Tg== X-Received: by 2002:a63:91c1:: with SMTP id l184mr3923243pge.29.1540413971332; Wed, 24 Oct 2018 13:46:11 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a1-v6sm9561222pfj.38.2018.10.24.13.46.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Oct 2018 13:46:11 -0700 (PDT) Date: Wed, 24 Oct 2018 13:46:02 -0700 From: Stephen Hemminger To: Dan Gora Cc: dev@dpdk.org, Igor Ryzhov , Ferruh Yigit Message-ID: <20181024134602.5511fa0b@xeon-e3> In-Reply-To: <20181024202719.24902-5-dg@adax.com> References: <20180911232906.18352-1-dg@adax.com> <20181024202719.24902-1-dg@adax.com> <20181024202719.24902-5-dg@adax.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 20:46:12 -0000 On Wed, 24 Oct 2018 17:27:18 -0300 Dan Gora wrote: > + pid = getpid(); > + RTE_LOG(INFO, APP, "========================\n"); > + RTE_LOG(INFO, APP, "KNI Running\n"); > + RTE_LOG(INFO, APP, "kill -SIGUSR1 %d\n", pid); > + RTE_LOG(INFO, APP, " Show KNI Statistics.\n"); > + RTE_LOG(INFO, APP, "kill -SIGUSR2 %d\n", pid); > + RTE_LOG(INFO, APP, " Zero KNI Statistics.\n"); > + RTE_LOG(INFO, APP, "========================\n"); > + fflush(stdout); > + Thanks for updating the example to cover the new code. This seems like an overly wordy message which should really be in the documentation not a billboard in the code. In my opinion, having verbose messages is unhelpful since it just clutters the experience.