From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id D059B4C9C for ; Wed, 24 Oct 2018 23:18:10 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id 32-v6so2936819pgu.2 for ; Wed, 24 Oct 2018 14:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c5mgQDbNUqrZgDPc4px9Mj5SyUomI2s8StAvtUjRi7A=; b=spLsnPRFxuLm+u4H+y/WZEIL7lANCk4197d1+grlOn+k5bQcUM861E89cwqOceG3KS EbY00d6jfr8yJUaw6J1fJuAm7yePbkC7K1yOxvtoM6krFymq8DS8dQuIhWGDnqly1d8r zTJLWrQ53nwCWgxQsDPFceP1KuRgdj8r3WEsZvHdsi6spgixIjBhtgXOON8PRzDelAWZ YpvMuv11T0S/2LuGFDceEhbWEw+WB6tUG3gFnXnzNA3c+SACMOzxSj1BdcXYOIljChmO sBNMLIhxAbFBKftscTD8Akuv4czC4L5GpoYkJ5ISJr4iD9TiLQ/QvI/58q7ZYppvhY/2 iUQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c5mgQDbNUqrZgDPc4px9Mj5SyUomI2s8StAvtUjRi7A=; b=CqsjawOkIIAZXvAMHnFEJD56gdX5cztvG6KGsGWLAyp5e2U74lrGU5bAQwyG4bUbLG 3AtsI/M/jSkS6CI4I4E/sQzva7HKk5sUOuj8kfvf5qEESKt/oeG5lKrXkkHu9ty/Nogb e8E5cD0iSUDdpkUlGTJRNP4Sj6Xozch+r0NV0+vUdTPr/c3RI2B8DEOCSStf01tRxN1r kN5/55Uo5+3VrmPVN+DIiETgGAvPkbcNf6liHIfXmGJLLKE3A8wN/5xIaxmpI+EPDg28 RrDZeMXU7WBiPguPHX4mMaZOvIXSFr+6v56v+lYtaZxZI5Zj6+XNTdYCZf4OoAxbW6xt MTJw== X-Gm-Message-State: AGRZ1gKU/KeaVBrWhT71YevJlR5kKrOUppQegn2frkkUK9MY3jQE/sqP ZUR2VTiAhBWUJnZDlW4KQrkXKw== X-Google-Smtp-Source: AJdET5eYQVCQItCSKORv9JbHlM8rXyIZ7CHIC0vC+maOoqy2j+2q9X2UpwiLlWnVNjJR2sFDeQBDrw== X-Received: by 2002:a65:47cb:: with SMTP id f11-v6mr4109090pgs.166.1540415889732; Wed, 24 Oct 2018 14:18:09 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w63-v6sm7001957pgw.60.2018.10.24.14.18.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Oct 2018 14:18:09 -0700 (PDT) Date: Wed, 24 Oct 2018 14:17:58 -0700 From: Stephen Hemminger To: Dan Gora Cc: dev@dpdk.org, Igor Ryzhov , Ferruh Yigit Message-ID: <20181024141758.1302d77b@xeon-e3> In-Reply-To: References: <20180911232906.18352-1-dg@adax.com> <20181024202719.24902-1-dg@adax.com> <20181024202719.24902-5-dg@adax.com> <20181024134602.5511fa0b@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 21:18:11 -0000 On Wed, 24 Oct 2018 17:56:50 -0300 Dan Gora wrote: > On Wed, Oct 24, 2018 at 5:46 PM Stephen Hemminger > wrote: > > > + pid = getpid(); > > > + RTE_LOG(INFO, APP, "========================\n"); > > > + RTE_LOG(INFO, APP, "KNI Running\n"); > > > + RTE_LOG(INFO, APP, "kill -SIGUSR1 %d\n", pid); > > > + RTE_LOG(INFO, APP, " Show KNI Statistics.\n"); > > > + RTE_LOG(INFO, APP, "kill -SIGUSR2 %d\n", pid); > > > + RTE_LOG(INFO, APP, " Zero KNI Statistics.\n"); > > > + RTE_LOG(INFO, APP, "========================\n"); > > > + fflush(stdout); > > > + > > > > Thanks for updating the example to cover the new code. > > > > This seems like an overly wordy message which should really be in the documentation > > not a billboard in the code. > > > > In my opinion, having verbose messages is unhelpful since it just clutters > > the experience. > > Sigh... > > This is version 6 of this patch. You could have said something about > it at any point in the last two and a half months that I have been > struggling to get this merged. > > These "features" were never documented at all, so you would have no > idea they existed unless you read the code. > > The point of this patch is that you can just copy and paste the > commands directly from the screen. This saves you from having to type > 'ps -ef|grep kni', cut the PID, type 'kill -SIGUSR1', then paste the > PID. How is that easier that what I have done? > > And it's not a billboard, it's 7 lines. Have you actually tried it? > > The amount of nitpicking on these patches has been just incredible.. > People get entire subsystems merged with 1/10th the hassle that I've > been given to add one stupid function. It's extremely frustrating. > I've totally given up on trying to get my other KNI patches merged.. > It's just not worth it.. > > dan I look at patches as they show up and don't want to overwhelm people with a long laundry list of items. Just a case of call them as I see them. Often a developer is focused on "does my feature work" and misses how the new feature is not used by most people. Remember when working on projects that the unstated policy is that all code should look the same. Anything you introduce should look like everything around it. Yes, this limits taste and individual freedom, but if you want to change things then doing it in new code is not the way to do it. The patch can go in as is. There is no reason for a message to block that. Just trying to see what can be improved. Don't get disheartened, 6 versions of a patch is nothing bad. Sometimes it takes 20 or more until agreement occurs.