From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by dpdk.org (Postfix) with ESMTP id 4213444BE for ; Wed, 24 Oct 2018 22:27:33 +0200 (CEST) Received: by mail-qk1-f193.google.com with SMTP id r71so11495qkr.10 for ; Wed, 24 Oct 2018 13:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AdYJeZmpldsSBeOmpoATKBbEqmIhIfvsS/ikpHI6hN0=; b=IV80PXfWfaNP/v+kSKSTS2AM8HoGZEblvB3n0iUnbryur0+a28+Zw21RU1ywl+hIne s5b6nqDIRlbe3uE9FjEH9E0rzTNuntRrw/2HdDJjGEOxdOOqF0CMwcDLFgvczV4FmNKg 9vcwqWEKFXPl/gU7I+BfvYbE2GmwhKBpHHhVGfp1v6DLZSpQSAPfUp8tPgeeKZoEk8Rk dscWV458/s1XYAKGOt3UuSU+fTB5XQnUwkMFyF8JaJIMxeTcuzugma/SzitLVECbI0+X I1trXdmIILBNuZ1CT/GNmrcqBfhbod4vxuBPZRgX5zD5cP3GJt9sIFgmT3jl55dV4fQX y1jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=AdYJeZmpldsSBeOmpoATKBbEqmIhIfvsS/ikpHI6hN0=; b=MI+EHTrwTFAW+NAlSoo6arRAkkZ4HXGP3nISQ3L8k7KtE2MzSCpZe4M6T62KClNUhx qq/vfZJfFcMWlke6A5PMwN/tcXFEDpJJFnpAv6oseoBzyJOTBrGWjXU3IlrbcRz3EtIv ZesGMudhIPCBSBtd1DaVZBYNzG2DgCInFkEtzacs2Lq+mbd9hLwdBwZOy99Uevzny/mI pSEC5gFamhGQoh6GoePgYiHcNcUOifOgJfpXl7CgOdMXAiWQ9KCiz3oHpYHS9F7LCXgR +pSwz5LgQ03yW4dOYNCna24oMyVGPDS08vWHCd8InPtK81Z9efuvb+qOxmx9R1amj7LY i/9g== X-Gm-Message-State: AGRZ1gJFBOVM361SnE83u1oBpK/1DLO927HPP/6Djz/dN6aHfaEorGIQ PKV2YFKuahj0VvbLm5ObtQpkbPsd X-Google-Smtp-Source: AJdET5e+Jo4Y0JKGXKBH+j1FlW1UnutCZwLKNrUHxYGMSJARPHDX0j0/bF6CGIBBYJjCgXQgay8tTQ== X-Received: by 2002:a37:b9c6:: with SMTP id j189-v6mr3790665qkf.203.1540412852079; Wed, 24 Oct 2018 13:27:32 -0700 (PDT) Received: from snappy.local.lan ([179.228.213.114]) by smtp.gmail.com with ESMTPSA id p64-v6sm3509117qkc.96.2018.10.24.13.27.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 Oct 2018 13:27:30 -0700 (PDT) Sender: Dan Gora From: Dan Gora To: dev@dpdk.org Cc: Igor Ryzhov , Stephen Hemminger , Ferruh Yigit , Dan Gora Date: Wed, 24 Oct 2018 17:27:14 -0300 Message-Id: <20181024202719.24902-1-dg@adax.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180911232906.18352-1-dg@adax.com> References: <20180911232906.18352-1-dg@adax.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v6 0/5] kni: add API to set link status on kernel interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 20:27:33 -0000 Hi All, Attached is version 6 of a patchset to add a new API function to set the link status on kernel interfaces created with the KNI kernel module. v6 ==== * Update info about callback functions in KNI library documentation. * Minor fixup to module parameter formatting in KNI kernel module. (align the "charp" text...) * Add '-m' flag to KNI sample app command line in KNI sample app documentation. * Add references to KNI library documentation from KNI sample app documentation (yay Sphinx!) > v5 > ==== > * Update Kernel NIC Interface document with new rte_kni option, move > kernel module parameter description here from KNI sample app > document, general cleanup. > > * Update Kernel NIC Interface sample application (kni) document > with new command line parameter, remove documentation for rte_kni > kernel module but add reference to it, general cleanup. > > * Change link status change sample rate for KNI example app to 500ms > from 100ms. > > * Fix bug in parameter parsing in v4 in rte_kni kernel module. > > * Fix output formatting of optional parameters for rte_kni with > modinfo. > > * Fix permissions of optional parameters for rte_kni. > > * Squash patch to add test for rte_kni_update_link into patch > introducing the API function. > > v4 > ==== > * Rework rte_kni_update_link to only take linkup/linkdown as parameter, > return previous link state, and remove log messages. > > * Update patch to set default carrier state to make default carrier > state configurable by passing the 'carrier=[on|off]' option to > the rte_kni kernel module. This is necessary in order to allow > applications which use KNI as pure virtual interfaces without > corresponding physical ethernet port to use the interfaces without > having to set the carrier state to 'on' via rte_kni_update_link() > or by writing to /sys/devices/virtual/net//carrier. > Note that the default is 'off'. > > * Add command line flag '-m' to examples/kni to continuously monitor > and update the KNI interface link status according to the link > status of the corresponding physical ethernet port. > > > v3 > ==== > * Use separate function to test rte_kni_update_link() in 'test' app. > > * Separate changes to 'test' app into separate patch to facilitate > possible merge with https://patches.dpdk.org/patch/44730/ > > * Remove changes to set KNI interfaces to 'up' in example/kni > > v2 > ==== > > * Fix bug where "Fixed" and "AutoNeg" were transposed in the link > status log message. > > * Add rte_kni_update_link() to rte_kni_version.map > > * Add rte_kni_update_link() tests to kni_autotest > > * Update examples/kni to continuously monitor link status and > update the corresponding kernel interface with > rte_kni_update_link(). > > * Minor improvements to examples/kni: Add log message showing how > to show/zero stats. Improve zeroing statistics. > > Note that checkpatches.sh compains about patch 1/5, but this appears > to be a bug with check-symbol-change or something. If I move the > fragment of the patch modifying rte_kni_version.map to the bottom of > the patch file, it doesn't complain any more... I just don't really > have time to investigate this right now. thanks dan Dan Gora (5): kni: add API to set link status on kernel interface kni: set default carrier state of interface examples/kni: monitor and update link status continually examples/kni: add log msgs to show and clear stats examples/kni: improve zeroing statistics .../prog_guide/kernel_nic_interface.rst | 239 ++++++++++++++--- .../sample_app_ug/kernel_nic_interface.rst | 251 +++++++++++------- examples/kni/Makefile | 2 + examples/kni/main.c | 92 ++++++- kernel/linux/kni/kni_dev.h | 3 + kernel/linux/kni/kni_misc.c | 60 ++++- kernel/linux/kni/kni_net.c | 5 + lib/librte_kni/rte_kni.c | 41 +++ lib/librte_kni/rte_kni.h | 20 ++ lib/librte_kni/rte_kni_version.map | 6 + test/test/test_kni.c | 77 ++++++ 11 files changed, 641 insertions(+), 155 deletions(-) -- 2.19.0