From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C91214C99 for ; Thu, 25 Oct 2018 11:46:18 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 02:46:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,423,1534834800"; d="scan'208";a="100559736" Received: from btwcube1.sh.intel.com (HELO debian) ([10.67.104.158]) by fmsmga004.fm.intel.com with ESMTP; 25 Oct 2018 02:46:17 -0700 Date: Thu, 25 Oct 2018 17:44:54 +0800 From: Tiwei Bie To: Jens Freimann Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com Message-ID: <20181025094454.GA24608@debian> References: <20181024143236.21271-1-jfreimann@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181024143236.21271-1-jfreimann@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v9 0/8] implement packed virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 09:46:19 -0000 On Wed, Oct 24, 2018 at 04:32:28PM +0200, Jens Freimann wrote: > This is a basic implementation of packed virtqueues as specified in the > Virtio 1.1 draft. A compiled version of the current draft is available > at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at > https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf > > A packed virtqueue is different from a split virtqueue in that it > consists of only a single descriptor ring that replaces available and > used ring, index and descriptor pointers. > > Each descriptor is readable and writable and has a flags field. These flags > will mark if a descriptor is available or used. To detect new available descriptors > even after the ring has wrapped, device and driver each have a > single-bit wrap counter that is flipped from 0 to 1 and vice versa every time > the last descriptor in the ring is used/made available. Do we have the performance numbers which can show the performance improvements in driver and vhost? Thanks > > v8-v9: > * fix virtio_ring_free_chain_packed() to handle descriptors > correctly in case of out-of-order > * fix check in virtqueue_xmit_cleanup_packed() to improve performance > > v7->v8: > * move desc_is_used change to correct patch > * remove trailing newline > * correct xmit code, flags update and memory barrier > * move packed desc init to dedicated function, split > and packed variant > > > Jens Freimann (8): > net/virtio: vring init for packed queues > net/virtio: add packed virtqueue defines > net/virtio: add packed virtqueue helpers > net/virtio: dump packed virtqueue data > net/virtio: implement transmit path for packed queues > net/virtio: implement receive path for packed queues > net/virtio: add virtio send command packed queue support > net/virtio: enable packed virtqueues by default > > drivers/net/virtio/virtio_ethdev.c | 154 ++++++-- > drivers/net/virtio/virtio_ethdev.h | 5 + > drivers/net/virtio/virtio_pci.h | 7 + > drivers/net/virtio/virtio_ring.h | 105 +++++- > drivers/net/virtio/virtio_rxtx.c | 560 +++++++++++++++++++++++++++-- > drivers/net/virtio/virtqueue.c | 22 ++ > drivers/net/virtio/virtqueue.h | 42 ++- > 7 files changed, 841 insertions(+), 54 deletions(-) > > -- > 2.17.1 >