From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 39FE756A3 for ; Thu, 25 Oct 2018 15:54:51 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 959C765991; Thu, 25 Oct 2018 13:54:50 +0000 (UTC) Received: from localhost (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D684C605BE; Thu, 25 Oct 2018 13:54:46 +0000 (UTC) Date: Thu, 25 Oct 2018 15:54:44 +0200 From: Jens Freimann To: Tiwei Bie Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com Message-ID: <20181025135444.ckans6yggoykaca7@jenstp.localdomain> References: <20181024143236.21271-1-jfreimann@redhat.com> <20181024143236.21271-5-jfreimann@redhat.com> <20181025092539.GD22179@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181025092539.GD22179@debian> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 25 Oct 2018 13:54:50 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v9 4/8] net/virtio: dump packed virtqueue data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 13:54:51 -0000 On Thu, Oct 25, 2018 at 05:25:40PM +0800, Tiwei Bie wrote: >On Wed, Oct 24, 2018 at 04:32:32PM +0200, Jens Freimann wrote: >> Add support to dump packed virtqueue data to the >> VIRTQUEUE_DUMP() macro. >> >> Signed-off-by: Jens Freimann >> Reviewed-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtqueue.h | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h >> index 3d512fe30..2af1bc259 100644 >> --- a/drivers/net/virtio/virtqueue.h >> +++ b/drivers/net/virtio/virtqueue.h >> @@ -368,6 +368,15 @@ virtqueue_notify(struct virtqueue *vq) >> uint16_t used_idx, nused; \ >> used_idx = (vq)->vq_ring.used->idx; \ >> nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \ >> + if (vtpci_packed_queue((vq)->hw)) { \ >> + PMD_INIT_LOG(DEBUG, \ >> + "VQ: - size=%d; free=%d; used_cons_idx=%d; avail_idx=%d;" \ >> + "VQ: - avail_wrap_counter=%d; used_wrap_counter=%d", \ > >Please remove the second "VQ: -" as they are on the same line. ok regards, Jens