From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1A0F27D52 for ; Thu, 25 Oct 2018 16:41:21 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6FA353082A3D; Thu, 25 Oct 2018 14:41:20 +0000 (UTC) Received: from localhost (ovpn-116-124.ams2.redhat.com [10.36.116.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 705421054FBB; Thu, 25 Oct 2018 14:41:15 +0000 (UTC) Date: Thu, 25 Oct 2018 16:41:13 +0200 From: Jens Freimann To: Tiwei Bie Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com Message-ID: <20181025144113.npc2fpa2m3frpm3r@jenstp.localdomain> References: <20181024143236.21271-1-jfreimann@redhat.com> <20181024143236.21271-3-jfreimann@redhat.com> <20181025092236.GB22179@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181025092236.GB22179@debian> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 25 Oct 2018 14:41:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v9 2/8] net/virtio: add packed virtqueue defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 14:41:21 -0000 On Thu, Oct 25, 2018 at 05:22:37PM +0800, Tiwei Bie wrote: >On Wed, Oct 24, 2018 at 04:32:30PM +0200, Jens Freimann wrote: >> Signed-off-by: Jens Freimann >> --- >> drivers/net/virtio/virtio_ring.h | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h >> index e65da100b..f84ab5e34 100644 >> --- a/drivers/net/virtio/virtio_ring.h >> +++ b/drivers/net/virtio/virtio_ring.h >> @@ -15,7 +15,10 @@ >> #define VRING_DESC_F_WRITE 2 >> /* This means the buffer contains a list of buffer descriptors. */ >> #define VRING_DESC_F_INDIRECT 4 >> - >> +/* This flag means the descriptor was made available by the driver */ >> +#define VRING_DESC_F_AVAIL(b) ((uint16_t)(b) << 7) >> +/* This flag means the descriptor was used by the device */ >> +#define VRING_DESC_F_USED(b) ((uint16_t)(b) << 15) > >Please add an empty line here. ok regards, Jens > >> /* The Host uses this in used->flags to advise the Guest: don't kick me >> * when you add a buffer. It's unreliable, so it's simply an >> * optimization. Guest will still kick if it's out of buffers. */ >> -- >> 2.17.1 >>