From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 47E535398 for ; Fri, 26 Oct 2018 15:51:23 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 06:51:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,428,1534834800"; d="scan'208";a="81793843" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga008.fm.intel.com with ESMTP; 26 Oct 2018 06:51:21 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id w9QDpKEe017848; Fri, 26 Oct 2018 14:51:20 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id w9QDpKTN009689; Fri, 26 Oct 2018 14:51:20 +0100 Received: (from lma25@localhost) by sivswdev01.ir.intel.com with LOCAL id w9QDpKaF009682; Fri, 26 Oct 2018 14:51:20 +0100 Date: Fri, 26 Oct 2018 14:51:20 +0100 From: "Liang, Ma" To: David Hunt Cc: dev@dpdk.org Message-ID: <20181026135120.GE1349@sivswdev01.ir.intel.com> References: <20181026123824.56349-1-david.hunt@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181026123824.56349-1-david.hunt@intel.com> User-Agent: Mutt/1.4.2.3i Subject: Re: [dpdk-dev] [PATCH] power: fix traffic aware compilation errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 13:51:23 -0000 Hi Dave, Many thanks! Regards Liang On 26 Oct 13:38, David Hunt wrote: > 1. %ld to PRId64 for 32-bit builds > 2. Fix dependency on librte_timer > > Fixes: 450f0791312c ("power: add traffic pattern aware power control") > > Signed-off-by: David Hunt > Tested-by: Ferruh Yigit > --- > lib/Makefile | 2 +- > lib/librte_power/rte_power_empty_poll.c | 13 +++++++------ > 2 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/lib/Makefile b/lib/Makefile > index 8c839425d..9ad10e0b6 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -71,7 +71,7 @@ DEPDIRS-librte_bitratestats := librte_eal librte_metrics librte_ethdev > DIRS-$(CONFIG_RTE_LIBRTE_LATENCY_STATS) += librte_latencystats > DEPDIRS-librte_latencystats := librte_eal librte_metrics librte_ethdev librte_mbuf > DIRS-$(CONFIG_RTE_LIBRTE_POWER) += librte_power > -DEPDIRS-librte_power := librte_eal > +DEPDIRS-librte_power := librte_eal librte_timer > DIRS-$(CONFIG_RTE_LIBRTE_METER) += librte_meter > DEPDIRS-librte_meter := librte_eal > DIRS-$(CONFIG_RTE_LIBRTE_FLOW_CLASSIFY) += librte_flow_classify > diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c > index c1e10e02d..e6145462f 100644 > --- a/lib/librte_power/rte_power_empty_poll.c > +++ b/lib/librte_power/rte_power_empty_poll.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > > #include "rte_power.h" > #include "rte_power_empty_poll.h" > @@ -226,8 +227,8 @@ update_stats(struct priority_worker *poll_stats) > > /* edpi mean empty poll counter difference per interval */ > RTE_LOG(DEBUG, POWER, "cur_edpi is too large " > - "cur edpi %ld " > - "base edpi %ld\n", > + "cur edpi %"PRId64" " > + "base edpi %"PRId64"\n", > cur_edpi, > s->thresh[s->cur_freq].base_edpi); > /* Value to make us fail need debug log*/ > @@ -261,7 +262,7 @@ update_stats_normal(struct priority_worker *poll_stats) > enum freq_val cur_freq = poll_stats->cur_freq; > > /* edpi mean empty poll counter difference per interval */ > - RTE_LOG(DEBUG, POWER, "cure freq is %d, edpi is %lu\n", > + RTE_LOG(DEBUG, POWER, "cure freq is %d, edpi is %"PRIu64"\n", > cur_freq, > poll_stats->thresh[cur_freq].base_edpi); > return; > @@ -346,14 +347,14 @@ empty_poll_training(struct priority_worker *poll_stats, > > set_state(poll_stats, MED_NORMAL); > > - RTE_LOG(INFO, POWER, "LOW threshold is %lu\n", > + RTE_LOG(INFO, POWER, "LOW threshold is %"PRIu64"\n", > poll_stats->thresh[LOW].base_edpi); > > - RTE_LOG(INFO, POWER, "MED threshold is %lu\n", > + RTE_LOG(INFO, POWER, "MED threshold is %"PRIu64"\n", > poll_stats->thresh[MED].base_edpi); > > > - RTE_LOG(INFO, POWER, "HIGH threshold is %lu\n", > + RTE_LOG(INFO, POWER, "HIGH threshold is %"PRIu64"\n", > poll_stats->thresh[HGH].base_edpi); > > RTE_LOG(INFO, POWER, "Training is Complete for %d\n", > -- > 2.17.1 >