DPDK patches and discussions
 help / color / mirror / Atom feed
From: Xiaolong Ye <xiaolong.ye@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye <xiaolong.ye@intel.com>
Subject: [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK
Date: Sat, 27 Oct 2018 18:40:24 +0800	[thread overview]
Message-ID: <20181027104032.10251-1-xiaolong.ye@intel.com> (raw)

Hi,

This patch series is to correct the wrong setting of
XXX_TX_OFFLOAD_MASK in multiple PMDs.

Just as the name XXX_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the
mask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or in
XXX_TX_OFFLOAD_MASK), however, xor will not get desired result here,
assume bit 0 of PKT_TX_OFFLOAD_MASK and XXX_TX_OFFLOAD_MAKS are 0 which
means corresponding feature is not supported in both sides, then we get
value of bit 0 of XXX_TX_OFFLOAD_NOTSUP_MASK which is 0 via xor, it
implies that it is supported which doesn't meet our expectation.

Correct it by a NOT-AND operation.

Xiaolong Ye (8):
  net/ixgbe: correct offload not supported mask
  net/avf: correct offload not supported mask
  net/ena: correct offload not supported mask
  net/atlantic: correct offload not supported mask
  net/fm10k: correct offload not supported mask
  net/qede: correct offload not supported mask
  net/vmxnet3: correct offload not supported mask
  net/e1000: correct offload not supported mask

 drivers/net/atlantic/atl_rxtx.c    | 2 +-
 drivers/net/avf/avf_rxtx.h         | 2 +-
 drivers/net/e1000/em_rxtx.c        | 2 +-
 drivers/net/e1000/igb_rxtx.c       | 2 +-
 drivers/net/ena/ena_ethdev.c       | 2 +-
 drivers/net/fm10k/fm10k_rxtx.c     | 2 +-
 drivers/net/ixgbe/ixgbe_rxtx.c     | 2 +-
 drivers/net/qede/qede_rxtx.h       | 2 +-
 drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-10-27 10:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-27 10:40 Xiaolong Ye [this message]
2018-10-27 10:40 ` [dpdk-dev] [PATCH 1/8] net/ixgbe: correct offload not supported mask Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 2/8] net/avf: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 3/8] net/ena: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 4/8] net/atlantic: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 5/8] net/fm10k: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 6/8] net/qede: " Xiaolong Ye
2018-11-02 20:02   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-11-05  6:52     ` Shaikh, Shahed
2018-11-05 10:21       ` Ferruh Yigit
2018-10-27 10:40 ` [dpdk-dev] [PATCH 7/8] net/vmxnet3: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 8/8] net/e1000: " Xiaolong Ye
2018-11-01  5:35 ` [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK Zhao1, Wei
2018-11-02 19:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-11-05  8:56   ` Ye Xiaolong
2018-11-05 10:24     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181027104032.10251-1-xiaolong.ye@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).