DPDK patches and discussions
 help / color / mirror / Atom feed
From: Xiaolong Ye <xiaolong.ye@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	Xiaolong Ye <xiaolong.ye@intel.com>,
	pavel.belous@aquantia.com
Subject: [dpdk-dev] [PATCH 4/8] net/atlantic: correct offload not supported mask
Date: Sat, 27 Oct 2018 18:40:28 +0800	[thread overview]
Message-ID: <20181027104032.10251-5-xiaolong.ye@intel.com> (raw)
In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com>

Previously ATL_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead
to unexpected result, correct it by using a NOT-AND operation.

Fixes: 2b1472d7150c ("net/atlantic: implement Tx path")

Cc: pavel.belous@aquantia.com
Cc: stable@dpdk.org
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 drivers/net/atlantic/atl_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c
index fd909476c..7a4eaf191 100644
--- a/drivers/net/atlantic/atl_rxtx.c
+++ b/drivers/net/atlantic/atl_rxtx.c
@@ -26,7 +26,7 @@
 	PKT_TX_TCP_SEG)
 
 #define ATL_TX_OFFLOAD_NOTSUP_MASK \
-	(PKT_TX_OFFLOAD_MASK ^ ATL_TX_OFFLOAD_MASK)
+	~(PKT_TX_OFFLOAD_MASK & ATL_TX_OFFLOAD_MASK)
 
 /**
  * Structure associated with each descriptor of the RX ring of a RX queue.
-- 
2.17.1

  parent reply	other threads:[~2018-10-27 10:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-27 10:40 [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 1/8] net/ixgbe: correct offload not supported mask Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 2/8] net/avf: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 3/8] net/ena: " Xiaolong Ye
2018-10-27 10:40 ` Xiaolong Ye [this message]
2018-10-27 10:40 ` [dpdk-dev] [PATCH 5/8] net/fm10k: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 6/8] net/qede: " Xiaolong Ye
2018-11-02 20:02   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-11-05  6:52     ` Shaikh, Shahed
2018-11-05 10:21       ` Ferruh Yigit
2018-10-27 10:40 ` [dpdk-dev] [PATCH 7/8] net/vmxnet3: " Xiaolong Ye
2018-10-27 10:40 ` [dpdk-dev] [PATCH 8/8] net/e1000: " Xiaolong Ye
2018-11-01  5:35 ` [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK Zhao1, Wei
2018-11-02 19:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-11-05  8:56   ` Ye Xiaolong
2018-11-05 10:24     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181027104032.10251-5-xiaolong.ye@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=pavel.belous@aquantia.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).