From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 66D424CA5; Sat, 27 Oct 2018 12:41:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343962" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:41:09 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye , tomaszx.kulasek@intel.com Date: Sat, 27 Oct 2018 18:40:32 +0800 Message-Id: <20181027104032.10251-9-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> References: <20181027104032.10251-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 8/8] net/e1000: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 10:41:12 -0000 Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead to unexpected result, correct it by using a NOT-AND operation. Fixes: 2b76648872c9 ("net/e1000: add Tx preparation") Cc: tomaszx.kulasek@intel.com Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/e1000/em_rxtx.c | 2 +- drivers/net/e1000/igb_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index a9cd76518..c3fd2cd6e 100644 --- a/drivers/net/e1000/em_rxtx.c +++ b/drivers/net/e1000/em_rxtx.c @@ -55,7 +55,7 @@ PKT_TX_VLAN_PKT) #define E1000_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ E1000_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & E1000_TX_OFFLOAD_MASK) /** * Structure associated with each descriptor of the RX ring of a RX queue. diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index 25ff5f68f..055dff102 100644 --- a/drivers/net/e1000/igb_rxtx.c +++ b/drivers/net/e1000/igb_rxtx.c @@ -57,7 +57,7 @@ IGB_TX_IEEE1588_TMST) #define IGB_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ IGB_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & IGB_TX_OFFLOAD_MASK) /** * Structure associated with each descriptor of the RX ring of a RX queue. -- 2.17.1