From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Jerin.JacobKollanukkaran@cavium.com>
Received: from NAM04-BN3-obe.outbound.protection.outlook.com
 (mail-eopbgr680053.outbound.protection.outlook.com [40.107.68.53])
 by dpdk.org (Postfix) with ESMTP id 6D8F42B8C;
 Sat, 27 Oct 2018 17:34:10 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7HI+BR+DK7dPi2yfYDibCDpeRrx6488nsnrLnC45guc=;
 b=KDyjfzLBW0gd+WHuv5V/GqmCU1iWsZ3TOeocOWxJuabwkSZi4Lfm8dVxbu5j4f/GgDH3UUIzfezpVTvrhSSaT5YDWddMepb7PozOVELxfBNHMYBkWvdIvZIY/MEdUo9dGlMhE99QXyDxigUGLEAs0boVS7HyolD+TY7b5KqqdnQ=
Received: from SN6PR07MB5008.namprd07.prod.outlook.com (52.135.121.74) by
 SN6PR07MB5486.namprd07.prod.outlook.com (20.177.250.75) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1250.30; Sat, 27 Oct 2018 15:34:07 +0000
Received: from SN6PR07MB5008.namprd07.prod.outlook.com
 ([fe80::913d:1a21:cb40:16de]) by SN6PR07MB5008.namprd07.prod.outlook.com
 ([fe80::913d:1a21:cb40:16de%3]) with mapi id 15.20.1273.025; Sat, 27 Oct 2018
 15:34:07 +0000
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, "dev@dpdk.org"
 <dev@dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 "stable@dpdk.org" <stable@dpdk.org>, Ola Liljedahl <Ola.Liljedahl@arm.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 "chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of
 the tail
Thread-Index: AQHUZeLgVIzLlxh6Z0CB1nLN9ujqf6Ui+22AgBA+qwCAAGHqgP//p1wAgAAFzgA=
Date: Sat, 27 Oct 2018 15:34:07 +0000
Message-ID: <20181027153355.GA9367@jerin>
References: <1537172244-64874-2-git-send-email-gavin.hu@arm.com>
 <1874944.OrACW1nkDZ@xps> <20181027150024.GA2294@jerin>
 <17713879.gC9jYcxDUo@xps>
In-Reply-To: <17713879.gC9jYcxDUo@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [122.178.242.38]
x-clientproxiedby: SG2PR03CA0106.apcprd03.prod.outlook.com
 (2603:1096:4:7c::34) To SN6PR07MB5008.namprd07.prod.outlook.com
 (2603:10b6:805:ad::10)
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; SN6PR07MB5486;
 6:31souxMl/U3mm8+GVazC/SCTR9++BZ+sxaV+kMhE79GYjQhBxgH8bvsAXgHTKB8336D/SMgkuL/d8pzZAn7FoI7WJUpqD9j+ox+q1koA7h8828vhSaWUU1Zt8Fpd0Pv17Vk+7LhAYdbzLDUh4lc6iJuT1CLHm7E+cF0+b8ZuQgO1zGWpTXcQLLSwqfJaX6hjiosq4jiiKOlNep/CziVQDxBe2+jhztxXIgA7ycHkUUxGzZ3hPh+8GGCQZTchIqjeFdvaR5sZrbDfLcUAB5IBuSkbRou125i5jR+EGSHlAVUrb987PUBe28clDoZHPzuBguuytFDKktiZel8xiLmL6wZ+1I7jTo3eTfnyaz+2xG6oy5pyjUx0rdJLkM1jivhsDO4lHseeiy9RTgKzBabNCxO8FdiwDuVyKKwHECCY6E9Hbowbzd38nGZ/EtOOtIz3lgDb31mcR1u54YXyo1EwPA==;
 5:W1sPHvFK+yV+tDGYOTTGFTazlClbVbpe3kZ3whUm+FaZiwbTlAtE714I6G57Fz+uRB1FORLsOHN6BUOsHOz+ARiDZSohpFS+9qlRXAwWrUJ+nwHqQCegZx7k/NlnpIR/QILniKKwKGWsctlhpfzsBUoBqlSsdHpHldJc6GgZhcE=;
 7:p1h1dV8HR8G+MKOPMkJHdWGqy2sxE4pSkq7MdxpZeLG1NLkyIZA5s9tvVXvYc/0NzE4kGrFbHsBug13Vvm3Hg35abMoxREWfT5h7TYBXSUv3zDnimHY1w5RPBw+HrVvV98LOXfR/DNOp2XvPGmbR1RyHyfAUlwde5Fe6bFqkoariivn8YbPbt++MFu/2msCJjcSyo9xkJsl/PUfF0A/JqdvwFrWwQhF8yhAYglKMFnZrvFGZgcxc1BmYcofbeuBT
x-ms-office365-filtering-correlation-id: 32f8124f-46d3-4bed-7910-08d63c21a21a
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(7020095)(4652040)(4534185)(4627221)(201703031133081)(201702281549075)(5600074)(711020)(2017052603328)(7153060)(7193020);
 SRVR:SN6PR07MB5486; 
x-ms-traffictypediagnostic: SN6PR07MB5486:
x-microsoft-antispam-prvs: <SN6PR07MB54862FBD99D66F41D7F43FDEE3F10@SN6PR07MB5486.namprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(104084551191319)(228905959029699)(180628864354917); 
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231382)(944501410)(52105095)(93006095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095);
 SRVR:SN6PR07MB5486; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5486; 
x-forefront-prvs: 08381C729B
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(7916004)(39860400002)(376002)(136003)(396003)(366004)(346002)(13464003)(199004)(189003)(6512007)(52116002)(5660300001)(11346002)(53936002)(1076002)(2906002)(4326008)(42882007)(33656002)(2900100001)(6486002)(486006)(99286004)(476003)(6436002)(81156014)(6246003)(71200400001)(102836004)(6116002)(26005)(54906003)(5250100002)(68736007)(8676002)(446003)(33896004)(14454004)(97736004)(7416002)(72206003)(14444005)(7736002)(6916009)(9686003)(186003)(478600001)(106356001)(386003)(81166006)(305945005)(25786009)(71190400001)(316002)(256004)(3846002)(8936002)(66066001)(33716001)(93886005)(229853002)(76176011)(105586002)(6506007);
 DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5486;
 H:SN6PR07MB5008.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; A:1; MX:1; 
received-spf: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: W6/nC7KvDvxFB8rGTbEK4qMR7AjIEuv/JFDMXV5ZZ4OWcFD1PGlqGLdgs4+/54p9+AjtPm53YwdoQl968DgkeO++/ElKEV/CGgKtK2VBRr/mjswwhai5wJgpwyOl4/gVv196pws4WEcqzxt6a0PMGLZs+rI1sm6qpWYUlI19ycgqEtm+X2XVQ3rekB0c59ejR4GhGD2T2sWhXmxSun/jXiFAQldw5T3YpGQJfAfNA4ieRdkUKVe9Chksk5WILqEvJYhoyV/6TwjDqy/zNqDk4k8vaeX+9xDzSuOxOrGMIXpFhKiLLOWrPUDIQqzb+kzucao3D9Xm8mZ7boDEC8uUouRhHyURQOjaoJE7DimO0r0=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A2CC35A43F48C84F8737EB037F899FFB@namprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32f8124f-46d3-4bed-7910-08d63c21a21a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2018 15:34:07.7559 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5486
Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of
 the tail
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2018 15:34:10 -0000

-----Original Message-----
> Date: Sat, 27 Oct 2018 17:13:10 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, "dev@dpdk.org"
>  <dev@dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
>  "stable@dpdk.org" <stable@dpdk.org>, Ola Liljedahl
>  <Ola.Liljedahl@arm.com>, "olivier.matz@6wind.com"
>  <olivier.matz@6wind.com>, "chaozhu@linux.vnet.ibm.com"
>  <chaozhu@linux.vnet.ibm.com>, "bruce.richardson@intel.com"
>  <bruce.richardson@intel.com>, "konstantin.ananyev@intel.com"
>  <konstantin.ananyev@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store =
of
>  the tail
>=20
>=20
> 27/10/2018 17:00, Jerin Jacob:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 17/10/2018 08:35, Gavin Hu (Arm Technology China):
> > > > Hi Jerin
> > > >
> > > > As the 1st one of the 3-patch set was not concluded, I submit this =
2-patch series to unblock the merge.
> > >
> > > The thread is totally messed up because:
> > >         - there is no cover letter
> > >         - some different series (testpmd, i40e and doc) are in the sa=
me thread
> > >         - v4 replies to a different series
> > >         - this version should be a v5 but has no number
> > >         - this version replies to the v3
> > >         - patchwork still shows v3 and "v5"
> > >         - replies from Ola are not quoting previous discussion
> > >
> > > Because of all of this, it is really difficult to follow.
> > > This is probably the reason of the lack of review outside of Arm.
> > >
> > > One more issue: you must Cc the relevant maintainers.
> > > Here:
> > >         - Olivier for rte_ring
> > >         - Chao for IBM platform
> > >         - Bruce and Konstantin for x86
> > >
> > > Guys, it is really cool to have more Arm developpers in DPDK.
> > > But please consider better formatting your discussions, it is really
> > > important in our contribution workflow.
> > >
> > > I don't know what to do.
> > > I suggest to wait for more feedbacks and integrate it in -rc2.
> >
> > This series has been acked and tested. Sure, if we are looking for some
> > more feedback we can push to -rc2 if not it a good candidate to be
> > selected for -rc1.
>=20
> It has been acked and tested only for Arm platforms.
> And Olivier, the ring maintainer, was not Cc.
>=20
> I feel it is not enough.

Sure, More reviews is already better. But lets keep as -rc2 target.


>=20
>=20