From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0061.outbound.protection.outlook.com [104.47.32.61]) by dpdk.org (Postfix) with ESMTP id E8BA7DED; Mon, 29 Oct 2018 11:16:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZF1CXZVqpeHXeSHBlNvv6hKvA1l0PK9qOsIG8k+wdtQ=; b=jJARfA8/LDXUutX3K04KM/M/NKiNo+6GbpsQ4OS3xFEM2JKWk4Rr4j0OLtswnXYXrkab/JLCzuZcS4ySimJ7PNZjBM0qEo1Tw2Nmd+xU0Wenw7Znc8V5sfnMtnK1wYYkWysr091VsLVpT4hzzqTyMAzAMiW+MvDCUxOflEZND3o= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB5669.namprd07.prod.outlook.com (20.178.0.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.22; Mon, 29 Oct 2018 10:16:31 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc%2]) with mapi id 15.20.1273.027; Mon, 29 Oct 2018 10:16:31 +0000 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com> CC: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "stable@dpdk.org" <stable@dpdk.org>, Ola Liljedahl <Ola.Liljedahl@arm.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com> Thread-Topic: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail Thread-Index: AQHUZeLgVIzLlxh6Z0CB1nLN9ujqf6Ui+22AgBA+qwCAAGHqgP//p1wAgABiAICAAfUQgIAAeqOA Date: Mon, 29 Oct 2018 10:16:31 +0000 Message-ID: <20181029101612.GA4738@jerin> References: <1537172244-64874-2-git-send-email-gavin.hu@arm.com> <1874944.OrACW1nkDZ@xps> <20181027150024.GA2294@jerin> <17713879.gC9jYcxDUo@xps> <20181027153355.GA9367@jerin> <VI1PR08MB316781C8FE59C58537A122868FF30@VI1PR08MB3167.eurprd08.prod.outlook.com> In-Reply-To: <VI1PR08MB316781C8FE59C58537A122868FF30@VI1PR08MB3167.eurprd08.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [111.93.218.67] x-clientproxiedby: PN1PR0101CA0021.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::31) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5669; 6:x//wPqBFuqTCx0QqmA5qSElbfl26i3DL3A2JyGokvAjMoCmp2QcPe92tY6VRZJ3DWE4FdN3lkhebICQQ6SZSmwJIBMmWxVinQq74mIokfC9jJ8qpntw/spBNxZM3MBr0G393HCaXGZkpEjQTGp8aMDZbon3etgczNHy4TiCZ3kBrtmMWJeemVJ47zyxJ8gVq+bLq728kZFkLEQWNHmwdIKINnNXz8FRBgJfqWELOUridFwRQfEquDBTjfuIx/HNQwmKtYqzM6+m3UruUaa+4ydsC5alk2aYNWDtGQb7gRO+CCUN7owtE/e53gbPxsSed8srMFtDXjuI+xKKM14GPGLtEMIOxsdK8M2biQfHOeXf9n5ZO2Rj9Ejledqm+qSXza2qj6qGR/WAQGSiozlqWB72q1qVyWCEHgzkrN/AFPfkx01Gi8ynyR+LmPQUw2SEQyZxgZPZc8v2IMU/ZDeCyOQ==; 5:1INiF7DTBV3ApsLMZtJWMarAr0dQIsAMZIDTmcYd9fkFn9WNq7iOYcfymLn8cxSzjC52A+RhLEUc0mVZO8narrAq6idGU46pbTH2e2YstL6UyC5dof+TvL5Alf2TbmKgYVZw1UdJrIKbdtd2hgPGtEPiPbQF/YyDq19qJIm5y1Y=; 7:OmHo/jTJGbRsJTs2w+oalxr8mpc8BQNS/mUQL6BrKQLiKN5YR04HMyWjAG/h3jyi0IAPjHDMBgVn3vQ+5IGllmQu09O1MIavS236eYOtlbG8qvWK3SH/qvwo8Nf6vdXpwMAsa86uVvsmSp7pVaExSA== x-ms-office365-filtering-correlation-id: fa8eafbd-bc20-4157-61e7-08d63d879849 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5669; x-ms-traffictypediagnostic: BYAPR07MB5669: x-microsoft-antispam-prvs: <BYAPR07MB566954365DA1317EBC5D39DEE3F30@BYAPR07MB5669.namprd07.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(104084551191319)(228905959029699)(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(93006095)(10201501046)(3002001)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB5669; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5669; x-forefront-prvs: 084080FC15 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(7916004)(396003)(366004)(39850400004)(346002)(136003)(376002)(40434004)(13464003)(199004)(189003)(486006)(26005)(316002)(53936002)(446003)(11346002)(5660300001)(256004)(14444005)(229853002)(42882007)(5024004)(93886005)(14454004)(6246003)(186003)(105586002)(78486011)(72206003)(6916009)(305945005)(106356001)(7736002)(54906003)(7416002)(76176011)(71190400001)(9686003)(6512007)(6116002)(68736007)(81166006)(33896004)(5250100002)(97736004)(6486002)(8936002)(25786009)(102836004)(53546011)(6436002)(6506007)(2900100001)(478600001)(4326008)(99286004)(3846002)(33656002)(2906002)(66066001)(33716001)(8676002)(476003)(81156014)(52116002)(71200400001)(1076002)(386003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5669; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: qp4liS0wdHOdn/BYfB+th9qcio5AITVlLwE7mc16NOPvNqJeoLIeyIlFToYDH+UoVT+8lnUy0zjw7Z/P2LuU097AfPjkx56cqKYmd3mBubELcCW53u0KiI48QpU81VyluTAiuWxC0oKpc3cRYrMWwE3hJUQEdLlfJoP4Qsd1TDIIa02xbAG4MfDNxz2H0EG3sbGxJcmKUTkIVbbBxDQjkJTkcy/fguoHCrUbqC07AfkEisvD3npc/AHNjZIMk9T62QEcFmjJWUj1ZVMKAAOsV7wdc75YkKLBJFAgFJl1M1xgRmCi2eyHsveu4yBPbwWSbnXclHjNlz9w0ScLdtRtblZFJZYM4e9i3R207ED+I8k= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <4BE8BA22D1F33840B4F4D6B144B597A4@namprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa8eafbd-bc20-4157-61e7-08d63d879849 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2018 10:16:31.1048 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5669 Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 29 Oct 2018 10:16:33 -0000 -----Original Message----- > Date: Mon, 29 Oct 2018 02:57:17 +0000 > From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Thomas Monjalon > <thomas@monjalon.net> > CC: "dev@dpdk.org" <dev@dpdk.org>, Honnappa Nagarahalli > <Honnappa.Nagarahalli@arm.com>, "stable@dpdk.org" <stable@dpdk.org>, Ola > Liljedahl <Ola.Liljedahl@arm.com>, "olivier.matz@6wind.com" > <olivier.matz@6wind.com>, "chaozhu@linux.vnet.ibm.com" > <chaozhu@linux.vnet.ibm.com>, "bruce.richardson@intel.com" > <bruce.richardson@intel.com>, "konstantin.ananyev@intel.com" > <konstantin.ananyev@intel.com> > Subject: RE: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store = of > the tail >=20 >=20 > Hi Thomas and Jerin, >=20 > The patches were extensively reviewed by Arm internally, as the 1st patch= was not able to be concluded, I created a new patch series(2 patches). > How can I clean up this mess? > 1. make all the previous patches Superseded? > 2. We have two more new patches, should I submit the 4 patches (the old 2= patches + 2 new patches) with V2? I would suggest to supersede the old patches(not in this case, in any case = when you send new version and update the version number). I would suggest send new patches as separate series. If it has dependency o= n exiting Acked patches please mention that in cover letter. >=20 > Best Regards, > Gavin >=20 >=20 > > -----Original Message----- > > From: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Sent: Saturday, October 27, 2018 11:34 PM > > To: Thomas Monjalon <thomas@monjalon.net> > > Cc: Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>; dev@dpdk.org; > > Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; stable@dpdk.org; > > Ola Liljedahl <Ola.Liljedahl@arm.com>; olivier.matz@6wind.com; > > chaozhu@linux.vnet.ibm.com; bruce.richardson@intel.com; > > konstantin.ananyev@intel.com > > Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and stor= e of > > the tail > > > > -----Original Message----- > > > Date: Sat, 27 Oct 2018 17:13:10 +0200 > > > From: Thomas Monjalon <thomas@monjalon.net> > > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > Cc: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, > > "dev@dpdk.org" > > > <dev@dpdk.org>, Honnappa Nagarahalli > > <Honnappa.Nagarahalli@arm.com>, > > > "stable@dpdk.org" <stable@dpdk.org>, Ola Liljedahl > > > <Ola.Liljedahl@arm.com>, "olivier.matz@6wind.com" > > > <olivier.matz@6wind.com>, "chaozhu@linux.vnet.ibm.com" > > > <chaozhu@linux.vnet.ibm.com>, "bruce.richardson@intel.com" > > > <bruce.richardson@intel.com>, "konstantin.ananyev@intel.com" > > > <konstantin.ananyev@intel.com> > > > Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and > > > store of the tail > > > > > > > > > 27/10/2018 17:00, Jerin Jacob: > > > > From: Thomas Monjalon <thomas@monjalon.net> > > > > > 17/10/2018 08:35, Gavin Hu (Arm Technology China): > > > > > > Hi Jerin > > > > > > > > > > > > As the 1st one of the 3-patch set was not concluded, I submit t= his 2- > > patch series to unblock the merge. > > > > > > > > > > The thread is totally messed up because: > > > > > - there is no cover letter > > > > > - some different series (testpmd, i40e and doc) are in th= e same > > thread > > > > > - v4 replies to a different series > > > > > - this version should be a v5 but has no number > > > > > - this version replies to the v3 > > > > > - patchwork still shows v3 and "v5" > > > > > - replies from Ola are not quoting previous discussion > > > > > > > > > > Because of all of this, it is really difficult to follow. > > > > > This is probably the reason of the lack of review outside of Arm. > > > > > > > > > > One more issue: you must Cc the relevant maintainers. > > > > > Here: > > > > > - Olivier for rte_ring > > > > > - Chao for IBM platform > > > > > - Bruce and Konstantin for x86 > > > > > > > > > > Guys, it is really cool to have more Arm developpers in DPDK. > > > > > But please consider better formatting your discussions, it is > > > > > really important in our contribution workflow. > > > > > > > > > > I don't know what to do. > > > > > I suggest to wait for more feedbacks and integrate it in -rc2. > > > > > > > > This series has been acked and tested. Sure, if we are looking for > > > > some more feedback we can push to -rc2 if not it a good candidate t= o > > > > be selected for -rc1. > > > > > > It has been acked and tested only for Arm platforms. > > > And Olivier, the ring maintainer, was not Cc. > > > > > > I feel it is not enough. > > > > Sure, More reviews is already better. But lets keep as -rc2 target. > > > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you.