From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM05-BY2-obe.outbound.protection.outlook.com (mail-eopbgr710060.outbound.protection.outlook.com [40.107.71.60]) by dpdk.org (Postfix) with ESMTP id 18D0610A3; Mon, 29 Oct 2018 12:11:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3TpXTjieYZ/OttG9l6/suZAoJqlg3Ywi1t2vtnR9rxo=; b=UnVBWatvk3Ze6HgTVsr6ZagZkmH4a9DymYGdbpkRYpYgymFKiE516B3Y6FtS/Iv/WutYlketmgDH3jl2vGtHY/mwKXdB9WCh1xa4qSPUMbMTdh6mXIbHCOxIRvLwCFDQZslAvCiz2Epd9xAHNuT+VUWLy/8Tgh5T8stUKbPU56Q= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB4455.namprd07.prod.outlook.com (52.135.225.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.26; Mon, 29 Oct 2018 11:10:58 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc%2]) with mapi id 15.20.1273.027; Mon, 29 Oct 2018 11:10:58 +0000 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, "dev@dpdk.org" <dev@dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "stable@dpdk.org" <stable@dpdk.org>, Ola Liljedahl <Ola.Liljedahl@arm.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com> Thread-Topic: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail Thread-Index: AQHUZeLgVIzLlxh6Z0CB1nLN9ujqf6Ui+22AgBA+qwCAAGHqgP//p1wAgABiAICAAfUQgIAA1tUA//+sbYCAAAacAA== Date: Mon, 29 Oct 2018 11:10:58 +0000 Message-ID: <20181029111043.GA10781@jerin> References: <1537172244-64874-2-git-send-email-gavin.hu@arm.com> <VI1PR08MB316781C8FE59C58537A122868FF30@VI1PR08MB3167.eurprd08.prod.outlook.com> <20181029101612.GA4738@jerin> <3665103.RQOKKVgJhj@xps> In-Reply-To: <3665103.RQOKKVgJhj@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [111.93.218.67] x-clientproxiedby: PN1PR0101CA0029.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::15) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB4455; 6:BeVdPwLDRbVPg5zhfPqyunh5xizkAHyUtmVvmsQmWTYVpEuFeQiyj6Xbyn+dCrIz+vsiFTJQiLswGK7nVf6/tC3I7U38GD/Mh0lM9WvIMmEyg/V2R8ScQfKABTfMzTuzSEY5bDp2T1ShzRTqqSI4swtj7aMRdIh+tgpQrMEn64CTjyD/sqmR0T2euz/oYs3AbOShqlKvnnT4ildXmq4OYdm4ACVTST78F+FeEatPPrhVGDsTlSFZBlL3AqMRT872FzeFhYv72mckgxduAT6MIe0LYXPNRQ4BpA1D9aYl1je4kUzWLIvSxXna0eeGQU0LM9pB/FXb0pDrYz31XoNdZ0xFBjx/g49cNt9Oi3Yy5I8REwiwnlHmyDXv+VaAEJfM1XVqU79udw1o3KmzbRXvijdg0q58zkUsUnBjHuu/ws/HC1+MBR5LWhk9onZ4WCgPBFitnxoc+oV90WhGFwc1Rw==; 5:+IbrXkVfrOosZG94wt8Vuzds+GNGOBvqiCHj/XkBmJN42SPc6Lv5WzSKjEU4lMo4T88lJkF/vvKzzeyICZFDAB/jqznVVhrw7g7zxcvavWw5/6GLEiu+LgiNzRPb2t4EvhmKwODLwLnYVW8e4IlY1mUQO3hxk8Op1/Q0tWorVAw=; 7:bSDKOPIQBy1IZRd6NlpA+pC2G+5xRjKPWlzroyTGMn6zoiT3ScZk8ALjXxaS6Kc5P0qkPei70yxFBHGC3Sf3he2Y3v4zd941Z7FfWRL/urRYHum7DuagwMWekttVxKW+/l8w2u+1nwjAKhMxVLF/ag== x-ms-office365-filtering-correlation-id: d81a04ea-84b5-4d7c-9932-08d63d8f33bf x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4455; x-ms-traffictypediagnostic: BYAPR07MB4455: x-microsoft-antispam-prvs: <BYAPR07MB4455B817FC3C2B8A8865EC7FE3F30@BYAPR07MB4455.namprd07.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(104084551191319)(228905959029699)(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(3231382)(944501410)(52105095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB4455; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4455; x-forefront-prvs: 084080FC15 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(366004)(39860400002)(136003)(346002)(376002)(396003)(13464003)(40434004)(199004)(189003)(2906002)(1076002)(97736004)(6486002)(6512007)(6916009)(2900100001)(6436002)(5250100002)(9686003)(5024004)(78486011)(72206003)(14444005)(256004)(68736007)(14454004)(229853002)(5660300001)(7416002)(486006)(478600001)(33716001)(8676002)(71190400001)(476003)(11346002)(446003)(3846002)(76176011)(99286004)(66066001)(305945005)(81156014)(8936002)(7736002)(81166006)(71200400001)(33896004)(316002)(26005)(186003)(42882007)(6506007)(4326008)(102836004)(6246003)(25786009)(53936002)(386003)(106356001)(54906003)(6116002)(105586002)(33656002)(93886005)(52116002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4455; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 3Aen2S3Sx9GXWZUEJ6NxM2eXmAenuWT0Y7G/Pr7STTogiq9msmRDFmQA+q7YNCIlnR0T8UKF95yX+V/EHaldhuzV+PJvaDlrqNeetRfVzqKoX1CnOhsNYztehZ18WfcHQnWYYj/IBlTznXgASrwqvkZglJ1Y/GwlydjfjQHAOe00jgyD1HJ+aaORQoO+913U2czMeg2VLayiyA2X8pWb7NEjpIbXG7x00nEIR7FtGtPoXTKjRhJLzn/dmkCJECiM2Q0a+pedRELNUz7dZsE2KHOpDYUYewBvy88THtf2hW7rLtPLG9xs5H/6q9q/Ou9aZC2PGH2SEEHdJTgvBjvdb5rJz1nyZhihSzKk/CFWcrs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <E09B60A520AD0349A9ECE93F7C732470@namprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: d81a04ea-84b5-4d7c-9932-08d63d8f33bf X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2018 11:10:58.4816 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4455 Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 29 Oct 2018 11:11:01 -0000 -----Original Message----- > Date: Mon, 29 Oct 2018 11:47:05 +0100 > From: Thomas Monjalon <thomas@monjalon.net> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Gavin Hu (Arm Technolo= gy > China)" <Gavin.Hu@arm.com> > Cc: "dev@dpdk.org" <dev@dpdk.org>, Honnappa Nagarahalli > <Honnappa.Nagarahalli@arm.com>, "stable@dpdk.org" <stable@dpdk.org>, Ola > Liljedahl <Ola.Liljedahl@arm.com>, "olivier.matz@6wind.com" > <olivier.matz@6wind.com>, "chaozhu@linux.vnet.ibm.com" > <chaozhu@linux.vnet.ibm.com>, "bruce.richardson@intel.com" > <bruce.richardson@intel.com>, "konstantin.ananyev@intel.com" > <konstantin.ananyev@intel.com> > Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store = of > the tail >=20 >=20 > 29/10/2018 11:16, Jerin Jacob: > > From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com> > > > > > > Hi Thomas and Jerin, > > > > > > The patches were extensively reviewed by Arm internally, as the 1st p= atch was not able to be concluded, I created a new patch series(2 patches). > > > How can I clean up this mess? > > > 1. make all the previous patches Superseded? > > > 2. We have two more new patches, should I submit the 4 patches (the o= ld 2 patches + 2 new patches) with V2? > > > > I would suggest to supersede the old patches(not in this case, in any c= ase when you > > send new version and update the version number). >=20 > Why not in this case? I did not mean in this case particular. I meant in all cases. > There are some old patches in patchwork which should be superseded. >=20 > > I would suggest send new patches as separate series. If it has dependen= cy on > > exiting Acked patches please mention that in cover letter. >=20 > I would suggest also to stop top-posting, it doesn't help reading threads= . >=20 >=20 > > > From: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > > From: Thomas Monjalon <thomas@monjalon.net> > > > > > 27/10/2018 17:00, Jerin Jacob: > > > > > > From: Thomas Monjalon <thomas@monjalon.net> > > > > > > > 17/10/2018 08:35, Gavin Hu (Arm Technology China): > > > > > > > > Hi Jerin > > > > > > > > > > > > > > > > As the 1st one of the 3-patch set was not concluded, I subm= it this 2- > > > > patch series to unblock the merge. > > > > > > > > > > > > > > The thread is totally messed up because: > > > > > > > - there is no cover letter > > > > > > > - some different series (testpmd, i40e and doc) are i= n the same > > > > thread > > > > > > > - v4 replies to a different series > > > > > > > - this version should be a v5 but has no number > > > > > > > - this version replies to the v3 > > > > > > > - patchwork still shows v3 and "v5" > > > > > > > - replies from Ola are not quoting previous discussio= n > > > > > > > > > > > > > > Because of all of this, it is really difficult to follow. > > > > > > > This is probably the reason of the lack of review outside of = Arm. > > > > > > > > > > > > > > One more issue: you must Cc the relevant maintainers. > > > > > > > Here: > > > > > > > - Olivier for rte_ring > > > > > > > - Chao for IBM platform > > > > > > > - Bruce and Konstantin for x86 > > > > > > > > > > > > > > Guys, it is really cool to have more Arm developpers in DPDK. > > > > > > > But please consider better formatting your discussions, it is > > > > > > > really important in our contribution workflow. > > > > > > > > > > > > > > I don't know what to do. > > > > > > > I suggest to wait for more feedbacks and integrate it in -rc2= . > > > > > > > > > > > > This series has been acked and tested. Sure, if we are looking = for > > > > > > some more feedback we can push to -rc2 if not it a good candida= te to > > > > > > be selected for -rc1. > > > > > > > > > > It has been acked and tested only for Arm platforms. > > > > > And Olivier, the ring maintainer, was not Cc. > > > > > > > > > > I feel it is not enough. > > > > > > > > Sure, More reviews is already better. But lets keep as -rc2 target. > > > > > > > > > > > > > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are = confidential and may also be privileged. If you are not the intended recipi= ent, please notify the sender immediately and do not disclose the contents = to any other person, use it for any purpose, or store or copy the informati= on in any medium. Thank you. >=20 >=20 >=20 >=20 >=20