From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D70B34CAB for ; Tue, 30 Oct 2018 11:38:39 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2018 03:38:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,444,1534834800"; d="scan'208";a="85314090" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga007.jf.intel.com with SMTP; 30 Oct 2018 03:38:36 -0700 Received: by (sSMTP sendmail emulation); Tue, 30 Oct 2018 10:38:36 +0000 Date: Tue, 30 Oct 2018 10:38:35 +0000 From: Bruce Richardson To: Luca Boccassi Cc: Ilya Maximets , dev@dpdk.org Message-ID: <20181030103835.GA16340@bricha3-MOBL.ger.corp.intel.com> References: <1539364001.8721.45.camel@debian.org> <6d16dc9e-c2f5-ba4b-eeb5-a9cdd8ac75bc@samsung.com> <1540827227.29722.8.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1540827227.29722.8.camel@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2] build: add meson.build for kni kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 10:38:40 -0000 On Mon, Oct 29, 2018 at 03:33:47PM +0000, Luca Boccassi wrote: > On Mon, 2018-10-29 at 17:09 +0300, Ilya Maximets wrote: > > > On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote: > > > > On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote: > > > > > A Kbuild is also included to allow users to use DKMS natively > > > > > without > > > > > additional code. > > > > > > > > > > Signed-off-by: Luca Boccassi > > > > > --- > > > > > v2: add local directory to -I and build sources list > > > > > recursively to > > > > >     fix build on Fedora > > > > > > > > > > > > > Yep, now seems to build for me on Fedora. One minor suggestion is > > > > to > > > > look > > > > to use the "console" keyword on the custom_target if possible. It > > > > should > > > > help prevent noticable stalls as make runs in the background. > > > > [Unfortunately, it's meson 0.48 onward only, so if conditionals > > > > are > > > > needed, > > > > just ignore this suggestion] > > > > > > Good idea, I just with 0.48, 0.47 and 0.41 and in all cases there > > > are > > > no complaints or errors, it's simply ignored in the older versions. > > > > Hmm. > > I have following on my Ubuntu 18.04 with dpdk v18.11-rc1: > > > > $ meson --version > > 0.45.1 > > > > $ meson build > > <...> > > kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword > > argument "console". > > WARNING: This will become a hard error in the future. > > WARNING: Unknown keyword arguments in target rte_kni: console > > <...> > > > > It builds, but prints above warning. > > > > Best regards, Ilya Maximets. > > Interesting, wonder why I didn't see that on 0.41! Anyway those > warnings are fine to ignore, especially in this case. > Probably because the warnings about unknown parameters only came in a later version of meson. Earlier versions just ignored them without warning. /Bruce