From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 97D70F94 for ; Tue, 30 Oct 2018 11:54:23 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2018 03:54:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,444,1534834800"; d="scan'208";a="92351882" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by FMSMGA003.fm.intel.com with SMTP; 30 Oct 2018 03:54:19 -0700 Received: by (sSMTP sendmail emulation); Tue, 30 Oct 2018 10:54:19 +0000 Date: Tue, 30 Oct 2018 10:54:18 +0000 From: Bruce Richardson To: Vipin Varghese Cc: john.mcnamara@intel.com, dev@dpdk.org, marko.kovacevic@intel.com, amol.patel@intel.com, stephen1.byrne@intel.com Message-ID: <20181030105418.GB16340@bricha3-MOBL.ger.corp.intel.com> References: <20181030045633.18859-1-vipin.varghese@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181030045633.18859-1-vipin.varghese@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v1] doc: add meson build to contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 10:54:24 -0000 On Tue, Oct 30, 2018 at 10:26:33AM +0530, Vipin Varghese wrote: > Patches has to be validated for meson builds. Updating documentation > for meson build steps in Checking Compilation category. > > Signed-off-by: Vipin Varghese > --- > doc/guides/contributing/patches.rst | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst > index a3d788024..494037778 100644 > --- a/doc/guides/contributing/patches.rst > +++ b/doc/guides/contributing/patches.rst > @@ -468,6 +468,15 @@ The recommended configurations and options to test compilation prior to submitti > export DPDK_DEP_PCAP=y > export DPDK_DEP_SSL=y > > +Compliation of patches has to be tested using meson:: > + > + ./devtools/test-meson-builds.sh' > + > +The default build target is for shared library. Build can be modified for > +static and cross build by > + > + * static by ``--default-library=static``. > + * arm cross build use ``--cross-file=`` to override default path. > If you are telling people to use test-meson-builds.sh, you don't need these instructions, since that script builds using both static and shared settings. The regular builds actually use "static" by default, not "shared", but note that that only affects app linkage - both libraries are always built. The test-meson-builds.sh script builds most of it's test cases using shared, simply for reasons of saving space on disk. Doing that number of static builds can use a *lot* [1.5G or more] of disk space. However, outside of using the script, DPDK builds default to using "static". /Bruce > Sending Patches > --------------- > -- > 2.17.1 >