From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700066.outbound.protection.outlook.com [40.107.70.66]) by dpdk.org (Postfix) with ESMTP id 54159201 for ; Thu, 1 Nov 2018 11:34:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WyHEtdjjzpS7ZEI968EEalnYZntxFSFIC+mBHoOYVbQ=; b=On+ebPpAJfj6S+ZMucPHVX0vHktt8oZHniuvW3PYufrGCqPrQzDFA+7cZ/57ieiFV4axuW8zqSIrd7m7mZ5+gwpp1kMADiDZYXMtBDDRyU5WeeMVyaDFMgNGeyz69u/y29O7yhpHVIL9ijmF1WLH5Ru/oOtMlDsaPhWvSGIl1YA= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB5176.namprd07.prod.outlook.com (20.176.254.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.26; Thu, 1 Nov 2018 10:34:09 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc%2]) with mapi id 15.20.1273.027; Thu, 1 Nov 2018 10:34:09 +0000 From: Jerin Jacob To: "Zhao1, Wei" CC: "Yigit, Ferruh" , "dev@dpdk.org" , "thomas@monjalon.net" , "arybchenko@solarflare.com" , "olivier.matz@6wind.com" , "Zhang, Qi Z" , "Xing, Beilei" , "Lu, Wenzhuo" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] DEV_RX_OFFLOAD_VLAN_EXTEND offload Thread-Index: AQHUbRp9BJBaBaueiEKymxbtSmi8sKUxiMUAgABraoCACMIsAIAADC8A Date: Thu, 1 Nov 2018 10:34:09 +0000 Message-ID: <20181101103346.GA17024@jerin> References: <20181026105559.GA6843@jerin> <1888b918-6871-eadc-6aa1-fbf6b0cf48fe@intel.com> <20181026143508.GA2616@jerin> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-clientproxiedby: BM1PR01CA0129.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:40::23) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5176; 6:b0q1RPjpQkIDFZyy+t4pXR4Vs2bSAY0qowLq6qqpMTnAht7Id5X8o8Dj7/1cUE/CXOHdQC93GKSI8pK/F/vaPJ6BfKg0OtjkWcjPrh3nRWXFt7FY2/wVo2E3QmnIMiIyjmotEXpvKQ/OjBBLmNo56/NZ7K4ralZHCkumRm8vxFkvAPJETtkOW0HrbTPquw4aBj+gFAnUOT02yRFurHflLcCodnH34TQyyDlvP9dfMY+MDFc00rhdjKCe3lW7YCgZfRZjX6gJvjc1Ii+BKD4fyfEO4kbyNIrNYzaPewaL7UcFlf4JnTWXnG9tikXE9KkF4+3gn8WGVGl8RfwzhwjrhSEy8sigwNWox/gyi5MeV3RuJGkYiLxaJ/hZZNJHTIUlvkop+xAnNaduPBLgR4S7kN8EiFd+DGCcqRIlneRmipnvje2EYoiJ/Y0hPIblf53IMYljvaz5iZqX8EA5tqbElQ==; 5:hvGzLsMSMEsmYUDif+FMWvSMYVz1M5lQ5aplfnOujokIG5aGbrC5yY1VZHqsrnACYvILLoH/iCz6KHnpXafQ6BLB1aWL/VbxDLs7PzP0MoZYfmzO+COSVquUETTO/VXRjOuOUX5TVYmfoA1U+34xNAVNULu+trKk1Xx6xnsZSDQ=; 7:qLHwVhAdOCbdp2C557vAY17OgzJeO2Z6FBxoxGFIAKk3a2Vn/7WZFYZqsybHxrEdFOHVZkWhiG6r+bMMMHC6LV6cmU62QrU2R87T1UuRoz4H9+7rsXj0ZpQv23U+JQd2PIdKtkgoBlHygthAV082qw== x-ms-office365-filtering-correlation-id: defc5823-7a06-4468-79cb-08d63fe58e52 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5176; x-ms-traffictypediagnostic: BYAPR07MB5176: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(3231382)(944501410)(52105095)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB5176; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5176; x-forefront-prvs: 0843C17679 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(39860400002)(136003)(346002)(366004)(396003)(376002)(189003)(199004)(13464003)(5660300001)(6916009)(8676002)(93886005)(2906002)(97736004)(2900100001)(25786009)(9686003)(3846002)(8936002)(6486002)(76176011)(186003)(6436002)(1076002)(81166006)(68736007)(4326008)(6116002)(26005)(33896004)(316002)(55236004)(6512007)(229853002)(52116002)(81156014)(386003)(11346002)(72206003)(7736002)(256004)(53546011)(6506007)(105586002)(106356001)(42882007)(478600001)(5250100002)(6246003)(71190400001)(33656002)(99286004)(486006)(54906003)(66066001)(53936002)(7416002)(305945005)(33716001)(14454004)(14444005)(102836004)(446003)(71200400001)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5176; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 9AE2AJba5B/wPHqHyYkYwk6YhuZBdOJOO334tvBGpXBU3JrNKLmKcS7bnX9njkHZzmwFXNV3vY7wRTLaGMMwqWUKazCsO/s18InPTxeS3mLaqB6PNdcRQ8IF6E0eH++eYxxIYQUH8YWkuIE/RNTk3PghePn/hwTgpLlFnNNn+XueHBG46FSXJrp8R74Gj46MXhex1VZfPXjOJ32rmZRQJUkExwQw0kerqBoQldw81PBQ7MN9gvoXe3hccqCmmahPT/pN9CBaEvi2cOuZYsrZexvo4rkoDuSoW009XpHWsRpRS7ukvZ8skL5uesaUOo6KKRlEVcd1x7bU0vXfnMyqODZYJivKsQ4tqjZT6RAus6U= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <9F5F61362AFC8044B7DF2BB031BA1B38@namprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: defc5823-7a06-4468-79cb-08d63fe58e52 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2018 10:34:09.4990 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5176 Subject: Re: [dpdk-dev] DEV_RX_OFFLOAD_VLAN_EXTEND offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 10:34:13 -0000 -----Original Message----- > Date: Thu, 1 Nov 2018 09:50:12 +0000 > From: "Zhao1, Wei" > To: Jerin Jacob , "Yigit, Ferruh" > > CC: "dev@dpdk.org" , "thomas@monjalon.net" > , "arybchenko@solarflare.com" > , "olivier.matz@6wind.com" > , "Zhang, Qi Z" , "Xing, > Beilei" , "Lu, Wenzhuo" , > "Ananyev, Konstantin" > Subject: RE: [dpdk-dev] DEV_RX_OFFLOAD_VLAN_EXTEND offload >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Friday, October 26, 2018 10:35 PM > > To: Yigit, Ferruh > > Cc: dev@dpdk.org; thomas@monjalon.net; arybchenko@solarflare.com; > > olivier.matz@6wind.com; Zhang, Qi Z ; Xing, Beile= i > > ; Lu, Wenzhuo ; Ananyev, > > Konstantin > > Subject: Re: [dpdk-dev] DEV_RX_OFFLOAD_VLAN_EXTEND offload > > > > -----Original Message----- > > > Date: Fri, 26 Oct 2018 14:40:42 +0100 > > > From: Ferruh Yigit > > > To: Jerin Jacob , "dev@dpdk.org" > > > > > > CC: "thomas@monjalon.net" , > > > "arybchenko@solarflare.com" , > > > "olivier.matz@6wind.com" , > > "qi.z.zhang@intel.com" > > > , "beilei.xing@intel.com" > > > , Wenzhuo Lu , > > > Konstantin Ananyev > > > Subject: Re: [dpdk-dev] DEV_RX_OFFLOAD_VLAN_EXTEND offload > > > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) > > > Gecko/20100101 > > > Thunderbird/52.9.1 > > > > > > > > > On 10/26/2018 11:56 AM, Jerin Jacob wrote: > > > > > > > > Does anyone know the expectation of > > DEV_RX_OFFLOAD_VLAN_EXTEND > > > > offload? Does not look like it is documented. > > > > > > > > Looks like it is very specific to Intel controllers, Based on 82599 > > > > HRM, it is following, not sure what is the real expectation from NI= C > > > > in normative terms. > > > > > > > > Extended VLAN. > > > > ------------- > > > > When set, all incoming Rx packets are expected to have at least one > > > > VLAN with the Ether type as defined in EXVET register. The packets > > > > can have an inner-VLAN that should be used for all filtering > > > > purposes. All Tx packets are expected to have at least one VLAN > > > > added to them by the host. In the case of an additional VLAN reques= t > > > > (VLE), the inner-VLAN is added by the hardware after the outer-VLAN= is > > added by the host. > > > > This bit should only be reset by a PCIe reset and should only be > > > > changed while Tx and Rx processes are stopped. > > > > The exception to this rule are MAC control packets such as flow > > > > control, 802.1x, LACP, etc. that never carry a VLAN tag of any type > > > > > > > > > > This looks similar to QinQ but it seems not, in ixgbe datasheet it ha= s: > > > > Yes. QinQ there is an already an offload called > > DEV_RX_OFFLOAD_QINQ_STRIP >=20 > Excuse me, I have some thought, is that right? > maybe DEV_RX_OFFLOAD_QINQ_STRIP and DEV_RX_OFFLOAD_VLAN_EXTEND is just tw= o thing that play a different role each. > DEV_RX_OFFLOAD_VLAN_EXTEND tell NIC to recognize QinQ PACKETS, it is a fi= lter for NIC. > DEV_RX_OFFLOAD_QINQ_STRIP tell nic to strip 2 inner and outer vlan head w= hen moving packets from nic to host memory. > I40e NIC is the normative terms when handling qinq packets. Yes, it makes sense if the meaning of DEV_RX_OFFLOAD_VLAN_EXTEND is QINQ filter. But it looks like not, as .vlan_filter_set ethdev callback accepts= =20 only single vlan id as "uint16_t vlan_id". If it needs to be treated as QinQ filter then QinQ vlan_ids needs to be send to driver through some means. Probably we may need to deprecate these vlan API in long-term and enable it through rte_flow. >=20 > > > > > > > > > > " > > > Double VLAN and Single VLAN Support > > > ----------------------------------- > > > <....> > > > This mode is used for systems where the near end switch adds the > > > outer VLAN header containing switching information. > > > <...> > > > " > > > > > > And it in this mode hw doesn't insert or strip the outer VLAN, it > > > expect SW does it. The ethernet type is not 0x88A8 but can be anythin= g > > > set on EXVET.VET_EXT. So looks like it is to let switch to add custom= VLAN > > tags and NIC to ignore them.