From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 3E67D5B32 for ; Thu, 1 Nov 2018 18:42:41 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id u13-v6so4062190pfm.4 for ; Thu, 01 Nov 2018 10:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZOSCegPh23Sfv3NXSEp1J2dLq25SzsS/sBCAN+NoHJA=; b=OzfoHuFbvMIpgx8OaQYpZ4gAyyFL1yskC+ODUTsbJYqoaptF+QBjrJQHn3IQnoKHlZ 3smGiH4oDE3z1kpiDi38r2qPKqndJxvxNg7WjpGCHwQTVv5Hf74GVuK8RU4/PDhPzliO df7UZyd3Iy/qHysLR7ZmpQE23h3KHpDbqy09z4+m1kpUJkBV51sqQN7rY7CC246lJ+mx s4AJUhUdNd9ZJnf7g5P1VS1MCU+JE8o0L7HRvsEhk88WzusT24cphoVH0h5S2yW0YQ3a 33Ro+goPhRpsFmrU6B8XuZ+OUl35kv6EEx6ramRoh1HaAmw9L/VAT5zi8JQ7UXuQhBEU j5kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZOSCegPh23Sfv3NXSEp1J2dLq25SzsS/sBCAN+NoHJA=; b=QgwunzxJ64H8JfypNvaUK59MJb35ieibpt2WzzXlm5l1miMjdxn6xMu9F55Y5MvyNv WQ9pE37Fro5e0ghaFBEmlWE+fljzlMRGScY+outxkDwxicCpgsyB0pzDLBeMyxbN/AJK wnbELOplIzM461moG4t3vj4cLPrrJ+uV3CqkJBOKqK/nGeWEY8XZtUtuXkdnIqXVSlYN 7DfJPwJ5/zSWcRg4QaS1x7/XQtgsptLEL7ka75o1VyrTr9E0RkT+bn5WskHw/S5ikNkc a+UDmF+0oKG8GHweLFueIBIjATKUbLEt1V2eRGXqVpQOCtCvEmjAJj/N1+m49ZGUN65X +qLQ== X-Gm-Message-State: AGRZ1gKu9ZEvV3kOrwftBZswnZYWTyLvqNj/+EVgtSww2ua9IhuKaGzk wZbHAPUQxiffCFYo+pwX5xJLkQckd9Q= X-Google-Smtp-Source: AJdET5cRgcmByavdkW/n3eFYT31vP284xH3jGnYMXq+1B3lIsnIojomrN/RHRb7wRLyRmUp/fAPosQ== X-Received: by 2002:a62:7597:: with SMTP id q145-v6mr8607441pfc.254.1541094160226; Thu, 01 Nov 2018 10:42:40 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n82-v6sm40247577pfg.21.2018.11.01.10.42.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Nov 2018 10:42:40 -0700 (PDT) Date: Thu, 1 Nov 2018 10:42:31 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Thomas Monjalon , Hemant Agrawal , Shreyansh Jain , dev@dpdk.org, stable@dpdk.org Message-ID: <20181101104231.1a4c1d72@xeon-e3> In-Reply-To: <20181101131951.91459-1-ferruh.yigit@intel.com> References: <20181101131951.91459-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 17:42:41 -0000 On Thu, 1 Nov 2018 13:19:50 +0000 Ferruh Yigit wrote: > build error: > In function =E2=80=98fman_if_init=E2=80=99, > .../drivers/bus/dpaa/base/fman/fman.c:186:2: > error: =E2=80=98strncpy=E2=80=99 output may be truncated copying 4095= bytes from a > string of length 4095 [-Werror=3Dstringop-truncation] > strncpy(__if->node_path, dpa_node->full_name, PATH_MAX - 1); >=20 > strncpy may result a not null-terminated string, > replaced it with rte_strscpy >=20 > Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit Maybe just use strlcpy instead of a DPDK specific function. That way if Gcc gets smarter it can check that as well.