From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0
Date: Thu, 1 Nov 2018 17:45:50 +0000 [thread overview]
Message-ID: <20181101174550.GA23396@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20181101104231.1a4c1d72@xeon-e3>
On Thu, Nov 01, 2018 at 10:42:31AM -0700, Stephen Hemminger wrote:
> On Thu, 1 Nov 2018 13:19:50 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> > build error:
> > In function ‘fman_if_init’,
> > .../drivers/bus/dpaa/base/fman/fman.c:186:2:
> > error: ‘strncpy’ output may be truncated copying 4095 bytes from a
> > string of length 4095 [-Werror=stringop-truncation]
> > strncpy(__if->node_path, dpa_node->full_name, PATH_MAX - 1);
> >
> > strncpy may result a not null-terminated string,
> > replaced it with rte_strscpy
> >
> > Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Maybe just use strlcpy instead of a DPDK specific function.
> That way if Gcc gets smarter it can check that as well.
+1
While I get the point of strscpy, if strlcpy is good enough for openbsd,
it's good enough for me! :-)
next prev parent reply other threads:[~2018-11-01 17:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 13:19 Ferruh Yigit
2018-11-01 12:49 ` Shreyansh Jain
2018-11-01 13:19 ` [dpdk-dev] [PATCH 2/2] eal: " Ferruh Yigit
2018-11-01 17:42 ` [dpdk-dev] [PATCH 1/2] bus/dpaa: " Stephen Hemminger
2018-11-01 17:45 ` Bruce Richardson [this message]
2018-11-01 18:21 ` Ferruh Yigit
2018-11-01 19:45 ` Thomas Monjalon
2018-11-02 19:06 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit
2018-11-02 19:06 ` [dpdk-dev] [PATCH v2 2/2] eal: " Ferruh Yigit
2018-11-04 21:38 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101174550.GA23396@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=shreyansh.jain@nxp.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).