From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 0/4] fixes for rte_hash with TSX
Date: Mon, 5 Nov 2018 17:39:09 +0000 [thread overview]
Message-ID: <20181105173913.61225-1-bruce.richardson@intel.com> (raw)
When testing with rte_hash library and TSX, a higher level of transaction
aborts was observed in some cases, especially with newer compilers. These
patches reduce aborts by ensuring that the compiler does not accidentally
insert instructions that cause aborts, and by adding in delays on retry to
avoid repeated collisions.
Bruce Richardson (2):
eal/x86: reduce contention when retrying TSX
test/test: improve output for hash read-write test
Yipeng Wang (2):
hash: fix extra TSX collisions with newer gcc
hash: add local cache for TSX region
.../common/include/arch/x86/rte_spinlock.h | 19 ++++++++++++++++---
lib/librte_eal/linuxapp/eal/eal_alarm.c | 2 ++
lib/librte_hash/rte_cmp_x86.h | 2 ++
lib/librte_hash/rte_cuckoo_hash.c | 7 ++++---
test/test/test_hash_readwrite.c | 20 +++++++++++---------
5 files changed, 35 insertions(+), 15 deletions(-)
--
1.8.5.6
next reply other threads:[~2018-11-05 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 17:39 Bruce Richardson [this message]
2018-11-05 17:39 ` [dpdk-dev] [PATCH 1/4] hash: fix TSX aborts with newer gcc Bruce Richardson
2018-11-05 17:39 ` [dpdk-dev] [PATCH 2/4] hash: add local cache for TSX region Bruce Richardson
2018-11-09 15:59 ` Bruce Richardson
2018-11-05 17:39 ` [dpdk-dev] [PATCH 3/4] eal/x86: reduce contention when retrying TSX Bruce Richardson
2018-11-05 17:39 ` [dpdk-dev] [PATCH 4/4] test/test: improve output for hash read-write test Bruce Richardson
2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 0/4] fixes for rte_hash with TSX Bruce Richardson
2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 1/4] hash: fix TSX aborts with newer gcc Bruce Richardson
2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 2/4] hash: add local cache for TSX region Bruce Richardson
2018-11-12 18:34 ` Honnappa Nagarahalli
2018-11-13 16:40 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-11-13 17:16 ` Honnappa Nagarahalli
2018-11-13 17:24 ` Wang, Yipeng1
2018-11-13 17:48 ` Bruce Richardson
2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 3/4] eal/x86: reduce contention when retrying TSX Bruce Richardson
2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 4/4] test/test: improve output for hash read-write test Bruce Richardson
2018-11-14 0:06 ` [dpdk-dev] [PATCH v2 0/4] fixes for rte_hash with TSX Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105173913.61225-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).