[dpdk-dev] [PATCH] examples/fips_validation: fix build

[dpdk-dev] [PATCH] examples/fips_validation: fix build

[Thomas Monjalon]

The example was not added to the Makefile and there are some
compilation errors:

examples/fips_validation/main.c: In function ‘prepare_aead_op’:
error: control reaches end of non-void function
examples/fips_validation/main.c: In function ‘prepare_auth_op’:
error: control reaches end of non-void function

Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
Cc: marko.kovacevic@intel.com

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 examples/Makefile               | 1 +
 examples/fips_validation/main.c | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/examples/Makefile b/examples/Makefile
index 356fcb1cd..33fe0e586 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -17,6 +17,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += distributor
 DIRS-y += ethtool
 DIRS-y += exception_path
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += server_node_efd
+DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += fips_validation
 DIRS-$(CONFIG_RTE_LIBRTE_FLOW_CLASSIFY) += flow_classify
 DIRS-y += flow_filtering
 DIRS-y += helloworld
diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 0a7e75fc8..85f54cbf0 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -459,6 +459,8 @@ prepare_auth_op(void)
 	}
 
 	rte_crypto_op_attach_sym_session(env.op, env.sess);
+
+	return 0;
 }
 
 static int
@@ -526,6 +528,8 @@ prepare_aead_op(void)
 	}
 
 	rte_crypto_op_attach_sym_session(env.op, env.sess);
+
+	return 0;
 }
 
 static int
-- 
2.19.0

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix build

[Ferruh Yigit]

On 11/5/2018 5:45 PM, Thomas Monjalon wrote:
> The example was not added to the Makefile and there are some
> compilation errors:
> 
> examples/fips_validation/main.c: In function ‘prepare_aead_op’:
> error: control reaches end of non-void function
> examples/fips_validation/main.c: In function ‘prepare_auth_op’:
> error: control reaches end of non-void function
> 
> Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
> Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
> Cc: marko.kovacevic@intel.com
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix build

[Thomas Monjalon]

05/11/2018 18:51, Ferruh Yigit:
> On 11/5/2018 5:45 PM, Thomas Monjalon wrote:
> > The example was not added to the Makefile and there are some
> > compilation errors:
> > 
> > examples/fips_validation/main.c: In function ‘prepare_aead_op’:
> > error: control reaches end of non-void function
> > examples/fips_validation/main.c: In function ‘prepare_auth_op’:
> > error: control reaches end of non-void function
> > 
> > Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
> > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
> > Cc: marko.kovacevic@intel.com
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied