* [dpdk-dev] [PATCH] app/testpmd: fix memory leak for tm object
@ 2018-11-05 16:21 Jasvinder Singh
2018-11-05 19:34 ` Ferruh Yigit
2018-11-06 10:23 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
0 siblings, 2 replies; 4+ messages in thread
From: Jasvinder Singh @ 2018-11-05 16:21 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, jingjing.wu, bernard.iremonger
Fixes memory leak for shared shaper object of the traffic manager.
Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
app/test-pmd/softnicfwd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/softnicfwd.c b/app/test-pmd/softnicfwd.c
index 7ff622806..94e6669d3 100644
--- a/app/test-pmd/softnicfwd.c
+++ b/app/test-pmd/softnicfwd.c
@@ -458,6 +458,7 @@ softport_tm_tc_node_add(portid_t port_id,
error->message,
shaper_profile_id);
+ free(tnp.shared_shaper_id);
return -1;
}
tnp.shaper_profile_id = shaper_profile_id;
@@ -473,6 +474,7 @@ softport_tm_tc_node_add(portid_t port_id,
error->message,
h->tc_node_id[pos][k]);
+ free(tnp.shared_shaper_id);
return -1;
}
shaper_profile_id++;
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix memory leak for tm object
2018-11-05 16:21 [dpdk-dev] [PATCH] app/testpmd: fix memory leak for tm object Jasvinder Singh
@ 2018-11-05 19:34 ` Ferruh Yigit
2018-11-06 10:23 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2018-11-05 19:34 UTC (permalink / raw)
To: Jasvinder Singh, dev; +Cc: jingjing.wu, bernard.iremonger
On 11/5/2018 4:21 PM, Jasvinder Singh wrote:
> Fixes memory leak for shared shaper object of the traffic manager.
>
> Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
- needs stable tag: "Cc: stable@dpdk.org"
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak for tm object
2018-11-05 16:21 [dpdk-dev] [PATCH] app/testpmd: fix memory leak for tm object Jasvinder Singh
2018-11-05 19:34 ` Ferruh Yigit
@ 2018-11-06 10:23 ` Jasvinder Singh
2018-11-12 16:43 ` Dumitrescu, Cristian
1 sibling, 1 reply; 4+ messages in thread
From: Jasvinder Singh @ 2018-11-06 10:23 UTC (permalink / raw)
To: dev; +Cc: stable, ferruh.yigit, jingjing.wu, bernard.iremonger
Fixes memory leak for shared shaper object of the traffic manager.
Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")
Cc: stable@dpdk.org
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
v2
- cc to stable@dpdk.org
app/test-pmd/softnicfwd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/softnicfwd.c b/app/test-pmd/softnicfwd.c
index 7ff622806..94e6669d3 100644
--- a/app/test-pmd/softnicfwd.c
+++ b/app/test-pmd/softnicfwd.c
@@ -458,6 +458,7 @@ softport_tm_tc_node_add(portid_t port_id,
error->message,
shaper_profile_id);
+ free(tnp.shared_shaper_id);
return -1;
}
tnp.shaper_profile_id = shaper_profile_id;
@@ -473,6 +474,7 @@ softport_tm_tc_node_add(portid_t port_id,
error->message,
h->tc_node_id[pos][k]);
+ free(tnp.shared_shaper_id);
return -1;
}
shaper_profile_id++;
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak for tm object
2018-11-06 10:23 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
@ 2018-11-12 16:43 ` Dumitrescu, Cristian
0 siblings, 0 replies; 4+ messages in thread
From: Dumitrescu, Cristian @ 2018-11-12 16:43 UTC (permalink / raw)
To: Singh, Jasvinder, dev
Cc: stable, Yigit, Ferruh, Wu, Jingjing, Iremonger, Bernard
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Tuesday, November 6, 2018 10:23 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix memory leak for tm object
>
> Fixes memory leak for shared shaper object of the traffic manager.
>
> Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding
> mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> v2
> - cc to stable@dpdk.org
>
> app/test-pmd/softnicfwd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied to next-pipeline tree, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-12 16:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05 16:21 [dpdk-dev] [PATCH] app/testpmd: fix memory leak for tm object Jasvinder Singh
2018-11-05 19:34 ` Ferruh Yigit
2018-11-06 10:23 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
2018-11-12 16:43 ` Dumitrescu, Cristian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).