From: Neil Horman <nhorman@tuxdriver.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test: fix build
Date: Tue, 6 Nov 2018 14:54:02 -0500 [thread overview]
Message-ID: <20181106195402.GA32558@hmswarspite.think-freely.org> (raw)
In-Reply-To: <20181106143501.6515-1-ferruh.yigit@intel.com>
On Tue, Nov 06, 2018 at 02:35:01PM +0000, Ferruh Yigit wrote:
> With "make -C test/" command getting following warnings:
> awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/'
> for reading (No such file or directory)
> awk: cmd. line:1: fatal: cannot open file
> `/test-pipeline/test-pipeline/' for reading (No such file or
> directory)
> awk: cmd. line:1: fatal: cannot open file `/test-acl/test-acl/'
> for reading (No such file or directory)
>
> This is because unexpected/invalid MAPFILE param passed to
> check-experimental-syms.sh
>
> There is no easy way to unify MAPFILE for different build options,
> instead add an input verification to script, and silently ignore wrong
> values.
>
> Fixes: a6ec31597a0b ("mk: add experimental tag check")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: nhorman@tuxdriver.com
> ---
> buildtools/check-experimental-syms.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
> index d0915102d..7d1f3a568 100755
> --- a/buildtools/check-experimental-syms.sh
> +++ b/buildtools/check-experimental-syms.sh
> @@ -5,6 +5,12 @@
> MAPFILE=$1
> OBJFILE=$2
>
> +# added check for "make -C test/" usage
> +if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
> +then
> + exit 0
> +fi
> +
> if [ -d $MAPFILE ]
> then
> exit 0
> --
> 2.17.2
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2018-11-06 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 14:35 Ferruh Yigit
2018-11-06 19:54 ` Neil Horman [this message]
2018-11-12 0:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106195402.GA32558@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).