From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id EF5202082;
 Tue,  6 Nov 2018 20:54:22 +0100 (CET)
Received: from [107.15.85.130] (helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1gJrXA-0003p9-VD; Mon, 05 Nov 2018 21:56:16 -0500
Date: Tue, 6 Nov 2018 14:54:02 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Message-ID: <20181106195402.GA32558@hmswarspite.think-freely.org>
References: <20181106143501.6515-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181106143501.6515-1-ferruh.yigit@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Score: 0.3 (/)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH] test: fix build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Nov 2018 19:54:23 -0000

On Tue, Nov 06, 2018 at 02:35:01PM +0000, Ferruh Yigit wrote:
> With "make -C test/" command getting following warnings:
>  awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/'
>       for reading (No such file or directory)
>  awk: cmd. line:1: fatal: cannot open file
>       `/test-pipeline/test-pipeline/' for reading (No such file or
>       directory)
>  awk: cmd. line:1: fatal: cannot open file `/test-acl/test-acl/'
>       for reading (No such file or directory)
> 
> This is because unexpected/invalid MAPFILE param passed to
> check-experimental-syms.sh
> 
> There is no easy way to unify MAPFILE for different build options,
> instead add an input verification to script, and silently ignore wrong
> values.
> 
> Fixes: a6ec31597a0b ("mk: add experimental tag check")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: nhorman@tuxdriver.com
> ---
>  buildtools/check-experimental-syms.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
> index d0915102d..7d1f3a568 100755
> --- a/buildtools/check-experimental-syms.sh
> +++ b/buildtools/check-experimental-syms.sh
> @@ -5,6 +5,12 @@
>  MAPFILE=$1
>  OBJFILE=$2
>  
> +# added check for "make -C test/" usage
> +if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
> +then
> +	exit 0
> +fi
> +
>  if [ -d $MAPFILE ]
>  then
>  	exit 0
> -- 
> 2.17.2
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>