From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id BDA212BE5 for ; Thu, 8 Nov 2018 22:38:45 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id c13-v6so10134280plz.13 for ; Thu, 08 Nov 2018 13:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7uLkWaGMNbJO/d1Vj/6BgvisJPNeOXBTr+0Uc/wNKUE=; b=RYHlZAWS27Mmqz8vnfIItGhVcPqQl/L/OzgdhE5mhqEzjnn3jCwFHwbtPQ2+WS+dsF vZXHfv9GSsoS8yaMlZCAC2jb1z1YCm7ZKwiRZ290d5lxQG4RizEARwbbAubcBlY2Bylf h0a37vTeZXJqE3mFccA4tNkCr7WG4RWW8Ek++Nly3chH6yQ35be+OhkM4erbDkxPKv0k Vh+fAj6B2WpE0hrV3H3O7soAnaY4BpMmPVtZrdEWo84FdxWmcQjDWHIvS4Ul5XXoqD7K up3fcGVDX12bejy6FiVj0kNrdsk9POFth10XGjip+5Lx9rkQDQLW1e68ClyEeDhUDD62 qhRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7uLkWaGMNbJO/d1Vj/6BgvisJPNeOXBTr+0Uc/wNKUE=; b=BvXtXo3sPxLax3u2Zoip9eeeww2Go5sTPIeUV0qDTmBvxljaKCnuVAlNSOcmgz/G0o 1EOuvPDRF3KA97NGL8tgCRUzgtHF2IODFEUBI3bxaKVJWCsLRnnfNgwacUFKbr1lzJ9N jlRyVSMheSSIGvlNNzdXOtH7ADstdhh1z5+1tVW/c5t0+2Zx9PgHVbitJScfoewnnVxb CgUgYmvOICfYY6HoZ9+Nps7IPv0ajrUWwe4505DcTvjeuauvDP0o887kjtJKIFWY608h GgHaOomQrENH7OIFM2yb5zPNQgAvifv9Syi27kROSDh4jMlvQzo0xsueH4MGhXiJ8drK SueQ== X-Gm-Message-State: AGRZ1gLFA32teACdoqDoBbMMW6KnhKgQvqnIZFnFZ1epN/wwBkGQGT/O FDGlSz6+nPglzmhfKsDqofx5RA== X-Google-Smtp-Source: AJdET5dmZm3qsAqBRF3ENnv1koAgvUfSlaIVLZ8EhV7c/F9pjBAEV109lGiFH7aSvRJ62YQGRB6mpw== X-Received: by 2002:a17:902:8d83:: with SMTP id v3-v6mr6184061plo.162.1541713124762; Thu, 08 Nov 2018 13:38:44 -0800 (PST) Received: from shemminger-XPS-13-9360 ([167.220.2.154]) by smtp.gmail.com with ESMTPSA id 79sm4220276pge.66.2018.11.08.13.38.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 13:38:44 -0800 (PST) Date: Thu, 8 Nov 2018 13:38:42 -0800 From: Stephen Hemminger To: "Mody, Rasesh" Cc: "dev@dpdk.org" , "ferruh.yigit@intel.com" , Dept-Eng DPDK Dev Message-ID: <20181108133842.63548c39@shemminger-XPS-13-9360> In-Reply-To: <1541711947-3714-1-git-send-email-rasesh.mody@cavium.com> References: <1541711947-3714-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix to use rte log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 21:38:46 -0000 On Thu, 8 Nov 2018 21:19:26 +0000 "Mody, Rasesh" wrote: > Use rte_log() rather than RTE_LOG() for dynamic logging. Rearrange > dynamic log types to the top and configurable log types to bottom. > Remove unused RTE_LIBRTE_BNX2X_DEBUG_TX_FREE > > Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name") > > Signed-off-by: Rasesh Mody Looks good to me. You might also want to address the excessive number of INFO messages in bnx2x.c. There are things like debug messages at INFO level, extra new lines and banner bars. Acked-by: Stephen Hemminger