DPDK patches and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
To: bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
	hemant.agrawal@nxp.com, chaozhu@linux.vnet.ibm.com,
	yipeng1.wang@intel.com, dharmik.thakkar@arm.com,
	gavin.hu@arm.com, honnappa.nagarahalli@arm.com, nd@arm.com
Subject: [dpdk-dev] [PATCH 0/4] hash: separate lf and rw lock lookup code paths
Date: Fri,  9 Nov 2018 10:39:13 -0600	[thread overview]
Message-ID: <20181109163917.16845-1-honnappa.nagarahalli@arm.com> (raw)

The lock-free algorithm has caused significant lookup
performance regression for certain use cases. The
regression is attributed to the use of non-relaxed
memory orderings.

To address the issue, 2 versions of the lookup functions
are created. One that uses the RW lock and the one that
is lock-free. This restores the performance regression
caused for use cases that used RW lock version of the
lookup function.

This series has been split into 4 commits to make the review
process easier. All of these should be squashed into a single
commit after the review process is over.

Honnappa Nagarahalli (4):
  hash: prepare for lock-free and rw-lock separation
  hash: remove rw-lock calls from lock-free functions
  hash: remove memory orderings from rw-lock lookup fns
  hash: separate lf and rw lock lookup code paths

 lib/librte_hash/rte_cuckoo_hash.c | 303 ++++++++++++++++++++++++++++--
 1 file changed, 289 insertions(+), 14 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-11-09 16:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 16:39 Honnappa Nagarahalli [this message]
2018-11-09 16:39 ` [dpdk-dev] [PATCH 1/4] hash: prepare for lock-free and rw-lock separation Honnappa Nagarahalli
2018-11-09 16:39 ` [dpdk-dev] [PATCH 2/4] hash: remove rw-lock calls from lock-free functions Honnappa Nagarahalli
2018-11-09 16:39 ` [dpdk-dev] [PATCH 3/4] hash: remove memory orderings from rw-lock lookup fns Honnappa Nagarahalli
2018-11-10  8:51   ` Jerin Jacob
2018-11-10 18:58     ` Honnappa Nagarahalli
2018-11-09 16:39 ` [dpdk-dev] [PATCH 4/4] hash: separate lf and rw lock lookup code paths Honnappa Nagarahalli
2018-11-10 18:55 ` [dpdk-dev] [PATCH v2 0/1] " Honnappa Nagarahalli
2018-11-10 18:55   ` [dpdk-dev] [PATCH v2 1/1] " Honnappa Nagarahalli
2018-11-11  7:48     ` Jerin Jacob
2018-11-13 16:37       ` Thomas Monjalon
2018-11-11 21:43     ` Wang, Yipeng1
2018-11-12  4:50       ` Honnappa Nagarahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109163917.16845-1-honnappa.nagarahalli@arm.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    --cc=dharmik.thakkar@arm.com \
    --cc=gavin.hu@arm.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=nd@arm.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).