From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 821D6378B for ; Tue, 13 Nov 2018 18:15:39 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id v18-v6so14201599wrt.8 for ; Tue, 13 Nov 2018 09:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HG9MXDEnsD7P4bzUdenJlp1HntYVGklUBnHNxjmnzvU=; b=lAd0ryf9KScvwAYGXy55XPqZs+5XuopHrEsjNZm+EgbFDBMZNAOHDmRdMqRLeA0qSH fK1XyBEPvuHXociB/T3PTuK6Krmvl88aEUCgSrqnicFvNGCXVI8nMcSMNiMVOIYolzz0 7XhGeMNUBB1AM3jSIr8KGbgBgrHkYiiMRSJWPAHFa5vb/Awopc9KRcYa13d0BUYnZzun xzANMuybphSGr9fEZbHHscZszOWN0txgFszqZfv7D6nPL54fuMWg5vE8zLbxkojjUpOq RXA8jN9t4o2ho2kfaw/u1JcR36TBCOiTqEJTwhfMild9Ic3ldXPo/U55hRr6eMyV8c6s TGyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HG9MXDEnsD7P4bzUdenJlp1HntYVGklUBnHNxjmnzvU=; b=RKNuaoRl1kLT7wlD7ucxLo/5PCQT1ccyhfjHOajWYJfLb36l7LnF8vkvODTb0ORwUM wUc2q6MUL7nIjzzqMU7L1P9sp66Yw+6sesL28naQmEt9DTsvKOcgpm6al+TE29iBatMa t28IFeyJWUY51OkO6pexQXACtp4fun8P4aLajML4avoEmoCtycjn1OZ2xVfTO8VN0d/k ifn+YO3luAEMqiXS4YT5M+pfRzXHQ3al72FH2DgyjaOS9Y1KMx9oG80+jEF/9a4MZY3g plaNYQuxla+5rU2FmqywRPXPU76zPnXjFSOoVJPpZAlFbwF0sjxq5RMBmPmkx50ighgP rqDQ== X-Gm-Message-State: AGRZ1gK4xtolm9K+m7Iq2ubem0j47qvZEKwfGkF5ylYlV1t1KgHwzvEf oiFmypyIJAVwr2DNztYAFcMaIw== X-Google-Smtp-Source: AJdET5dG6JGARSjdN6p6bKEn5pH9eed3Rdw/N5TAWBd9WwwrBktfWvpRVqR9u2S5I+NUAYeQkUC5YQ== X-Received: by 2002:adf:9170:: with SMTP id j103-v6mr5966261wrj.217.1542129339209; Tue, 13 Nov 2018 09:15:39 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h67-v6sm4445074wma.10.2018.11.13.09.15.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Nov 2018 09:15:38 -0800 (PST) Date: Tue, 13 Nov 2018 18:15:19 +0100 From: Adrien Mazarguil To: Ori Kam Cc: Ophir Munk , Yongseok Koh , Andrew Rybchenko , Ferruh Yigit , "dev@dpdk.org" , Thomas Monjalon , Asaf Penso , Shahaf Shuler , Olga Shern Message-ID: <20181113171519.GF17131@6wind.com> References: <1541582611-1609-1-git-send-email-ophirmu@mellanox.com> <20181107093109.GG4638@6wind.com> <20181107140604.GL4638@6wind.com> <20181107164118.GM4638@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 17:15:39 -0000 Again a bit late to the party, please see below. On Sun, Nov 11, 2018 at 09:35:22AM +0000, Ori Kam wrote: > > -----Original Message----- > > From: dev On Behalf Of Ophir Munk > > Sent: Friday, November 9, 2018 10:14 AM > > To: Yongseok Koh ; Adrien Mazarguil > > ; Andrew Rybchenko > > > > Cc: Ferruh Yigit ; dev@dpdk.org; Thomas Monjalon > > ; Asaf Penso ; Shahaf Shuler > > ; Olga Shern > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types > > > > > -----Original Message----- > > > From: Yongseok Koh > > > Sent: Friday, November 09, 2018 1:07 AM > > > To: Ophir Munk ; Adrien Mazarguil > > > ; Andrew Rybchenko > > > > > > Cc: Ferruh Yigit ; dev@dpdk.org; Thomas Monjalon > > > ; Asaf Penso ; Shahaf > > > Shuler ; Olga Shern > > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > > > types > > > > > > > > > - if (src.rss->key_len) { > > > + if (src.rss->key && src.rss->key_len) { > > > > > > but looks like we should conclude this thread first? > > > Or, does the fix make any sense regardless of having key_len=0 or key=null > > > for default key? > > > Having more sanity check is no harm usually... > > > > > > > > > Thanks, > > > Yongseok > > > > > > > The setfault is the result of commit a4391f8bae ("app/testpmd: set default RSS > > key as null"). > > Reverting this commit should fix the segfault but it also means there is no way > > to set default key (key=NULL) with testpmd. > > Need to check if this is only a testpmd limitation and not all applications > > limitation. > > > > We should decide how an application can set default RSS without knowing > > anything about keys. > > > > I agree with Adrian that the main criteria should be the length. > Maybe the set default RSS in testpmd should get new parameter. Since [1] was reverted and we seem to agree that a zero key_len should trigger a PMD-specific default key, this can already be requested with testpmd by overriding key_len, e.g.: flow create 1 pattern eth / end actions rss key_len 0 / end Using an empty string as the key would yield the same result but cannot be expressed on the command line yet. Note that specifying a key automatically overrides key_len, so key_len must be forced to 0 last to get PMD defaults: flow create 1 pattern eth / end actions rss key foo key_len 0 / end Here key_len is set to testpmd's default size when parsing "rss", updated to 3 when parsing "key foo" and updated once again when parsing "key_len 0". Lastly, while it would make sense for testpmd to use 0 as the default value, doing so yields inconsistent balancing results between vendors/devices as they all come with a different key. Same reason as initializing the RSS types field to the global rss_hf instead of 0. [1] "app/testpmd: revert setting default RSS" https://mails.dpdk.org/archives/dev/2018-November/118786.html -- Adrien Mazarguil 6WIND