From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com
 [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 0061B2C52
 for <dev@dpdk.org>; Mon, 19 Nov 2018 18:10:50 +0100 (CET)
Received: by mail-pg1-f194.google.com with SMTP id n2so6930827pgm.3
 for <dev@dpdk.org>; Mon, 19 Nov 2018 09:10:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Cx8t7TWaM6LK+VPpr91VoG/tDsw+qufq6YSgiU5qLuM=;
 b=xE0CbtDN0x8ziHcW7vyPvq90p2ZEn7j7b9Ob1QtzNysPvBZYUVH2Ds9QFk8YCCtnLk
 34sY2vTooF+gz7OAVQTKX09PKbCGUlCAWYwKjd1LNTaymVNNGTDSMJ2Eg36TMUWDaCl/
 LBzMIs/eX7rvUNSs7W1OvPzBkz83mLIdmG5DJPjG9sHg5rPmjZhse37J91PUHSxi+NE3
 OZAxSRbDXmis9GEDtaiPZrt78lA5VrnelSo/k5XEYu6KPSeBOBZnPXZSD1e4Je3PGGHm
 j33IUe+W4k8uyNgbdGeRd8Tik4YKEG4/J51eNZ/KGgzf9wGnC6IIsDk1Vz+fBNVLXPQu
 ySrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Cx8t7TWaM6LK+VPpr91VoG/tDsw+qufq6YSgiU5qLuM=;
 b=hgZSQh4quna09pbWrKqABNgeoeHcIy1CTI0D4vEVsX038kbVc3BhkSlKProFIoLBHo
 Z9STXflIaa0htz4Tx1dub76bu/z3oypFQheFvSwbqLc1aSUFXr5Ncwx6zbY2JpeGZx0e
 PWWIIyWHHqAdRXvMNxPH6m4cLLSN5BMbLKDglIYfQ46G0AouEMyg4VBXMxUz8qYFw5ho
 GbIZ9ZwK7GGt0tyd7Ctwe+CbxGk19M7LB9nUC54+K/QNdZ1CZMKpdYb/FLA4bCuXdYCL
 A12I7xIJyHXj9ZVSQE2J3TItsMFNiaZxIaSXXd/fIRY35PCHji55OQBDP6AOPXOur8zB
 Jr8g==
X-Gm-Message-State: AGRZ1gI8pEMUf2dALWQd8DnqsD/54RtzWSsCbbgND5QAmZGLZanDP8XD
 oUlqmqcVKnxJGkSntfA9Srxt5Q==
X-Google-Smtp-Source: AJdET5fGETCcWiwoOulNOdsFrlzAopHTe3Q+i1u+NctWGwegByqtHPmrm+Zsb8XFndC9cmqSkxWRsA==
X-Received: by 2002:a65:4142:: with SMTP id x2mr19078617pgp.356.1542647449991; 
 Mon, 19 Nov 2018 09:10:49 -0800 (PST)
Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id d11sm26655054pgi.25.2018.11.19.09.10.49
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 19 Nov 2018 09:10:49 -0800 (PST)
Date: Mon, 19 Nov 2018 09:10:42 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Leah Tekoa <Leah@Ethernitynet.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ouyang Changchun
 <changchun.ouyang@intel.com>
Message-ID: <20181119091042.1977b022@xeon-e3>
In-Reply-To: <9f22d89841c440c32235117e1a4fe223f97c7f8e.1542616118.git.leah@ethernitynet.com>
References: <9f22d89841c440c32235117e1a4fe223f97c7f8e.1542616118.git.leah@ethernitynet.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in
 rte_eth_set_queue_rate_limit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Nov 2018 17:10:51 -0000

On Mon, 19 Nov 2018 08:38:44 +0000
Leah Tekoa <Leah@Ethernitynet.com> wrote:

> -	link = dev->data->dev_link;
> +	memcpy(&link, &dev->data->dev_link, sizeof(struct rte_eth_link));
>  

If structure assignment and memcpy don't give same result, then
you have a buggy compiler.