Re: [dpdk-dev] [PATCH] eventdev: fix missing unlock in eth Rx adapter

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Wed, 21 Nov 2018 03:39:15 +0530
> From: nikhil.rao@intel.com
> To: dev@dpdk.org
> CC: Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] eventdev: fix missing unlock in eth Rx adapter
> X-Mailer: git-send-email 2.14.1.145.gb3622a4
> 
> 
> From: Nikhil Rao <nikhil.rao@intel.com>
> 
> In the eth Rx adapter SW service function,
> move the return to after the spinlock unlock.
> 
> Coverity issue: 302857
> Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop")
> CC: stable@dpdk.org
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 71d008cd1..8831bc35f 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -1165,8 +1165,8 @@ rxa_service_func(void *args)
>         if (rte_spinlock_trylock(&rx_adapter->rx_lock) == 0)
>                 return 0;
>         if (!rx_adapter->rxa_started) {
> -               return 0;
>                 rte_spinlock_unlock(&rx_adapter->rx_lock);
> +               return 0;
>         }
> 
>         stats = &rx_adapter->stats;
> --
> 2.14.1.145.gb3622a4
>