From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-eopbgr790048.outbound.protection.outlook.com [40.107.79.48]) by dpdk.org (Postfix) with ESMTP id A37C65F20; Wed, 21 Nov 2018 13:48:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0QZFzcJ0Tb43bMXhfIaPy9tEYg1rywS+wh7VnFdINZU=; b=Am/Jd0+fXsnCgXS3vV95OV8itNljj1mDWtlQ8pZfbB7kMFZxz7HuoumjgZFebqRN/UtCdthA/X6kJ9NsyMyGxRGFPdplbd6AifXlefCPrOMqa4CqY/aMWJ1wB5VLqoPZ82L/C1XPRKCLSkwHsk6kS4EqVUUCRkWwLZE27QaRM20= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB5720.namprd07.prod.outlook.com (20.178.0.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Wed, 21 Nov 2018 12:48:37 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc%3]) with mapi id 15.20.1339.027; Wed, 21 Nov 2018 12:48:37 +0000 From: Jerin Jacob To: "nikhil.rao@intel.com" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eventdev: fix missing unlock in eth Rx adapter Thread-Index: AQHUgYKjFFxFNh4MOU2c9k+2zuLPtqVaLfcA Date: Wed, 21 Nov 2018 12:48:37 +0000 Message-ID: <20181121124825.GA26812@jerin> References: <20181120220915.75201-1-nikhil.rao@intel.com> In-Reply-To: <20181120220915.75201-1-nikhil.rao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-clientproxiedby: BM1PR01CA0106.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::22) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5720; 6:+ecizNZRgiJxmcbja/qBEdk5esNODe6MPDtFq1BzrrfydkFFi5gZJNl/6jU5yrkeCGTpmBeVbCf/Th32+ygv1Z0gjd1zVVL7D/mz6JxbjFHx/ocE/q2M3ON5fRH6JuPoZbNKPqaPjLqj4FREKeFTYOZHllr6exG2Lo1KwBU2K87ggOjUHeodel+N9BOKIfbWsgit6nq8Uw5BvFa1Gh8vlPB1cNem6QQ8zAgwqXpprVwlGQ3ne7pSW/D5CW3XJUG2JncGP3n4iM6YUKqowQ01dsFjp2WzwUGaR1AtFr9MFF+1QJCSwXcyia/EGO3j4o+9GmvNJ6POTblgWfsXL5I5WHwcty/aOJnVJ3uesLSTcRn79NLhNhjDe8fHGLKcgIcNYyjCgXM5FLFi9x/FiHk8gWxLywtJFEkhpg8fTfVgzpn4QaeebOj6H5ewDHD0hJos4b6ZNAUYZ7XRrp/Yq6gMiA==; 5:B2z1gXpF43Oz3H0DSOKSM936KyunJCSvMFZD+2AWgujJ+YlmiWuwvnUEgbAzMGkUuYBR09FBcYjH3NzfxTWcDwYEnBwHRdoRRndnn9WrBQY2U4uageoS2yDxg9ReVz6NSV6uckWSMoeKWCwDH611f4MjBu7YYMCVsGAQPAuyrfI=; 7:blD1zzTkwPSg3C2Cik0MoxTkGz6bj3vu7ozRTMKDUl3fhEINbMlSwbtiyXQOajyNHZojyHhLVZt9OjwloZ3mtIDaIROcGqy3e1n5+Y9St6HSJJEkEQVBEBqwHG80EuJ1eLDcYDL+xapY0tVABu94lw== x-ms-office365-filtering-correlation-id: b50622f2-2258-4cf7-b07c-08d64fafa763 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5720; x-ms-traffictypediagnostic: BYAPR07MB5720: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3231442)(944501410)(52105112)(3002001)(148016)(149066)(150057)(6041310)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB5720; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5720; x-forefront-prvs: 08635C03D4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(346002)(396003)(136003)(39860400002)(376002)(366004)(13464003)(189003)(199004)(6916009)(5640700003)(7736002)(478600001)(33656002)(102836004)(33716001)(26005)(305945005)(53936002)(72206003)(186003)(6436002)(9686003)(486006)(6246003)(446003)(2900100001)(476003)(42882007)(66066001)(229853002)(2501003)(1076002)(3846002)(256004)(6116002)(105586002)(6486002)(14444005)(106356001)(4326008)(97736004)(2351001)(99286004)(55236004)(81156014)(6512007)(11346002)(81166006)(5660300001)(54906003)(8676002)(71190400001)(33896004)(2906002)(76176011)(14454004)(68736007)(316002)(6506007)(71200400001)(25786009)(52116002)(8936002)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5720; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Cj2fvSM8zSP9+t4cpwZupB/xi9cJ5GRW7jtb2/d0bhjmSMh6vL8CDwewQ+K+FOfINtYVX0Hp+oGLey1vGzxwT6UNiX+UwutGSmjYK1LgX7YBbRBGKolmS+U0KmBwO/svv7DnX9XIgLSXBD8lbH1lmEJav3dk7pOH2KV507UMlorMTsUQejB+gJF0Q3DBeK7HC5BiaTJg+fWMum/FCiFP8Ipqu1HqsXyhXkzRHCwxZPyxiuh5OJOGj2byEJ2bblhN45ZOQOXnUmksvyBEqIGKnMeq9fmTIqr64f21fMC0sc4tMyy/w9dQqn/bTNdFbbYxgNOMZ81vkz03B3gWNzzVjqnilw53maBj3l6x6T44MUk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: b50622f2-2258-4cf7-b07c-08d64fafa763 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2018 12:48:37.0836 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5720 Subject: Re: [dpdk-dev] [PATCH] eventdev: fix missing unlock in eth Rx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 12:48:39 -0000 -----Original Message----- > Date: Wed, 21 Nov 2018 03:39:15 +0530 > From: nikhil.rao@intel.com > To: dev@dpdk.org > CC: Nikhil Rao , stable@dpdk.org > Subject: [dpdk-dev] [PATCH] eventdev: fix missing unlock in eth Rx adapte= r > X-Mailer: git-send-email 2.14.1.145.gb3622a4 >=20 >=20 > From: Nikhil Rao >=20 > In the eth Rx adapter SW service function, > move the return to after the spinlock unlock. >=20 > Coverity issue: 302857 > Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop") > CC: stable@dpdk.org > Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob > --- > lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_= eventdev/rte_event_eth_rx_adapter.c > index 71d008cd1..8831bc35f 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > @@ -1165,8 +1165,8 @@ rxa_service_func(void *args) > if (rte_spinlock_trylock(&rx_adapter->rx_lock) =3D=3D 0) > return 0; > if (!rx_adapter->rxa_started) { > - return 0; > rte_spinlock_unlock(&rx_adapter->rx_lock); > + return 0; > } >=20 > stats =3D &rx_adapter->stats; > -- > 2.14.1.145.gb3622a4 >=20