From: wanlebing <wanlebing@gmail.com>
To: dev@dpdk.org
Cc: wanlebing <wanlebing@didichuxing.com>, wanlebing <wanlebing@gmail.com>
Subject: [dpdk-dev] [PATCH] ethdev: fix memory leak on removing eth rxtx callback
Date: Wed, 21 Nov 2018 21:11:27 +0800 [thread overview]
Message-ID: <20181121131127.28528-1-wanlebing@didichuxing.com> (raw)
eth rxtx callback is dynamically allocated using rte_zmalloc()
but not released. Fix it by calling rte_free() to free callback
when removing rxtx callback.
Signed-off-by: wanlebing <wanlebing@didichuxing.com>
Signed-off-by: wanlebing <wanlebing@gmail.com>
---
lib/librte_ethdev/rte_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 5f858174b..f00311047 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -3926,6 +3926,7 @@ rte_eth_remove_rx_callback(uint16_t port_id, uint16_t queue_id,
if (cb == user_cb) {
/* Remove the user cb from the callback list. */
*prev_cb = cb->next;
+ rte_free(cb);
ret = 0;
break;
}
@@ -3960,6 +3961,7 @@ rte_eth_remove_tx_callback(uint16_t port_id, uint16_t queue_id,
if (cb == user_cb) {
/* Remove the user cb from the callback list. */
*prev_cb = cb->next;
+ rte_free(cb);
ret = 0;
break;
}
--
2.14.1
next reply other threads:[~2018-11-21 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 13:11 wanlebing [this message]
2018-11-21 14:48 ` Ferruh Yigit
2018-11-22 2:32 ` 万乐冰
2018-11-23 2:25 ` lebing wan
2018-11-23 9:13 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121131127.28528-1-wanlebing@didichuxing.com \
--to=wanlebing@gmail.com \
--cc=dev@dpdk.org \
--cc=wanlebing@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).