* [dpdk-dev] [PATCH] security: restore experimental tag for unimplemented APIs
@ 2018-11-22 10:07 Akhil Goyal
2018-11-23 0:58 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Akhil Goyal @ 2018-11-22 10:07 UTC (permalink / raw)
To: dev
Cc: thomas, konstantin.ananyev, jerin.jacob, anoob.joseph,
radu.nicolau, declan.doherty, Hemant Agrawal, Akhil Goyal
Following APIs are not currently implemented by any of the
drivers, so marking them as rte_experimental again.
rte_security_get_userdata;
rte_security_session_stats_get;
rte_security_session_update;
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
lib/librte_security/rte_security.c | 6 +++---
lib/librte_security/rte_security.h | 6 +++---
lib/librte_security/rte_security_version.map | 8 ++++++++
3 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/lib/librte_security/rte_security.c b/lib/librte_security/rte_security.c
index bc81ce1..a222b33 100644
--- a/lib/librte_security/rte_security.c
+++ b/lib/librte_security/rte_security.c
@@ -33,7 +33,7 @@ rte_security_session_create(struct rte_security_ctx *instance,
return sess;
}
-int
+int __rte_experimental
rte_security_session_update(struct rte_security_ctx *instance,
struct rte_security_session *sess,
struct rte_security_session_conf *conf)
@@ -49,7 +49,7 @@ rte_security_session_get_size(struct rte_security_ctx *instance)
return instance->ops->session_get_size(instance->device);
}
-int
+int __rte_experimental
rte_security_session_stats_get(struct rte_security_ctx *instance,
struct rte_security_session *sess,
struct rte_security_stats *stats)
@@ -86,7 +86,7 @@ rte_security_set_pkt_metadata(struct rte_security_ctx *instance,
sess, m, params);
}
-void *
+void * __rte_experimental
rte_security_get_userdata(struct rte_security_ctx *instance, uint64_t md)
{
void *userdata = NULL;
diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h
index e07b132..718147e 100644
--- a/lib/librte_security/rte_security.h
+++ b/lib/librte_security/rte_security.h
@@ -344,7 +344,7 @@ rte_security_session_create(struct rte_security_ctx *instance,
* - On success returns 0
* - On failure return errno
*/
-int
+int __rte_experimental
rte_security_session_update(struct rte_security_ctx *instance,
struct rte_security_session *sess,
struct rte_security_session_conf *conf);
@@ -412,7 +412,7 @@ rte_security_set_pkt_metadata(struct rte_security_ctx *instance,
* - On success, userdata
* - On failure, NULL
*/
-void *
+void * __rte_experimental
rte_security_get_userdata(struct rte_security_ctx *instance, uint64_t md);
/**
@@ -499,7 +499,7 @@ struct rte_security_stats {
* - On success return 0
* - On failure errno
*/
-int
+int __rte_experimental
rte_security_session_stats_get(struct rte_security_ctx *instance,
struct rte_security_session *sess,
struct rte_security_stats *stats);
diff --git a/lib/librte_security/rte_security_version.map b/lib/librte_security/rte_security_version.map
index a77ca4b..36e2ac4 100644
--- a/lib/librte_security/rte_security_version.map
+++ b/lib/librte_security/rte_security_version.map
@@ -14,3 +14,11 @@ DPDK_18.11 {
local: *;
};
+
+EXPERIMENTAL {
+ global:
+
+ rte_security_get_userdata;
+ rte_security_session_stats_get;
+ rte_security_session_update;
+};
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] security: restore experimental tag for unimplemented APIs
2018-11-22 10:07 [dpdk-dev] [PATCH] security: restore experimental tag for unimplemented APIs Akhil Goyal
@ 2018-11-23 0:58 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-11-23 0:58 UTC (permalink / raw)
To: Akhil Goyal
Cc: dev, konstantin.ananyev, jerin.jacob, anoob.joseph, radu.nicolau,
declan.doherty, Hemant Agrawal
22/11/2018 11:07, Akhil Goyal:
> Following APIs are not currently implemented by any of the
> drivers, so marking them as rte_experimental again.
>
> rte_security_get_userdata;
> rte_security_session_stats_get;
> rte_security_session_update;
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
Fixes: 1a81dce780a0 ("security: remove experimental tag")
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-23 0:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-22 10:07 [dpdk-dev] [PATCH] security: restore experimental tag for unimplemented APIs Akhil Goyal
2018-11-23 0:58 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).