From: Qi Zhang <qi.z.zhang@intel.com>
To: bruce.richardson@intel.com, keith.wiles@intel.com,
konstantin.ananyev@intel.com
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, bernard.iremonger@intel.com,
Qi Zhang <qi.z.zhang@intel.com>
Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: improve MAC swap performance for x86
Date: Fri, 23 Nov 2018 01:26:31 +0800 [thread overview]
Message-ID: <20181122172632.6229-3-qi.z.zhang@intel.com> (raw)
In-Reply-To: <20181122172632.6229-1-qi.z.zhang@intel.com>
The patch optimizes the mac swap operation by taking advantage
of SSE instructions, it only impacts x86 platform.
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
app/test-pmd/macswap.c | 4 ++++
app/test-pmd/macswap_sse.h | 43 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 47 insertions(+)
create mode 100644 app/test-pmd/macswap_sse.h
diff --git a/app/test-pmd/macswap.c b/app/test-pmd/macswap.c
index 849194fe2..cbb41b728 100644
--- a/app/test-pmd/macswap.c
+++ b/app/test-pmd/macswap.c
@@ -66,7 +66,11 @@
#include <rte_flow.h>
#include "testpmd.h"
+#ifdef RTE_ARCH_X86
+#include "macswap_sse.h"
+#else
#include "macswap.h"
+#endif
/*
* MAC swap forwarding mode: Swap the source and the destination Ethernet
diff --git a/app/test-pmd/macswap_sse.h b/app/test-pmd/macswap_sse.h
new file mode 100644
index 000000000..d5b0f6a21
--- /dev/null
+++ b/app/test-pmd/macswap_sse.h
@@ -0,0 +1,43 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+
+#ifndef _L2FWD_SSE_H_
+#define _L2FWD_SSE_H_
+
+#include "macswap_common.h"
+static inline void
+do_macswap(struct rte_mbuf *pkts[], uint16_t nb,
+ struct rte_port *txp)
+{
+ struct ether_hdr *eth_hdr;
+ struct rte_mbuf *mb;
+ uint64_t ol_flags;
+ int i;
+ __m128i addr;
+ __m128i shfl_msk = _mm_set_epi8(15, 14, 13, 12,
+ 5, 4, 3, 2,
+ 1, 0, 11, 10,
+ 9, 8, 7, 6);
+
+ ol_flags = ol_flags_init(txp->dev_conf.txmode.offloads);
+
+ for (i = 0; i < nb; i++) {
+ if (likely(i < nb - 1))
+ rte_prefetch0(rte_pktmbuf_mtod(pkts[i+1], void *));
+ mb = pkts[i];
+
+ eth_hdr = rte_pktmbuf_mtod(mb, struct ether_hdr *);
+
+ /* Swap dest and src mac addresses. */
+ addr = _mm_loadu_si128((__m128i *)eth_hdr);
+ addr = _mm_shuffle_epi8(addr, shfl_msk);
+ _mm_storeu_si128((__m128i *)eth_hdr, addr);
+
+ mbuf_field_set(mb, ol_flags, txp->tx_vlan_id,
+ txp->tx_vlan_id_outer);
+ }
+}
+
+#endif /* _BPF_CMD_H_ */
+
--
2.13.6
next prev parent reply other threads:[~2018-11-22 17:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 17:26 [dpdk-dev] [PATCH 0/3] improve MAC swap performance Qi Zhang
2018-11-22 17:26 ` [dpdk-dev] [PATCH 1/3] app/testpmd: code refactory for macswap Qi Zhang
2018-11-22 17:26 ` Qi Zhang [this message]
2018-11-22 17:26 ` [dpdk-dev] [PATCH 3/3] app/testpmd: further improve MAC swap performance for x86 Qi Zhang
2018-11-22 17:38 ` [dpdk-dev] [PATCH v2 0/3] improve MAC swap performance Qi Zhang
2018-11-22 17:38 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: code refactory for macswap Qi Zhang
2018-12-10 17:44 ` Ferruh Yigit
2018-12-11 4:02 ` Zhang, Qi Z
2018-11-22 17:38 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: improve MAC swap performance for x86 Qi Zhang
2018-12-10 17:44 ` Ferruh Yigit
2018-11-22 17:38 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: further " Qi Zhang
2018-12-11 5:55 ` [dpdk-dev] [PATCH v2 0/3] improve MAC swap performance Qi Zhang
2018-12-11 5:55 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: code refactory for macswap Qi Zhang
2018-12-11 15:48 ` Ferruh Yigit
2018-12-14 11:14 ` Iremonger, Bernard
2018-12-14 11:21 ` Zhang, Qi Z
2018-12-11 5:55 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: improve MAC swap performance for x86 Qi Zhang
2018-12-13 19:50 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2018-12-14 11:21 ` [dpdk-dev] " Iremonger, Bernard
2018-12-14 11:36 ` Zhang, Qi Z
2018-12-11 5:55 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: further " Qi Zhang
2018-12-16 0:58 ` [dpdk-dev] [PATCH v3 0/3] improve MAC swap performance Qi Zhang
2018-12-16 0:58 ` [dpdk-dev] [PATCH v3 1/3] app/testpmd: code refactory for macswap Qi Zhang
2018-12-18 11:06 ` Iremonger, Bernard
2018-12-16 0:58 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: improve MAC swap performance for x86 Qi Zhang
2018-12-18 11:07 ` Iremonger, Bernard
2018-12-16 0:58 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: further " Qi Zhang
2018-12-18 11:09 ` Iremonger, Bernard
2018-12-18 0:15 ` [dpdk-dev] [PATCH v3 0/3] improve MAC swap performance Ferruh Yigit
2018-12-18 16:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122172632.6229-3-qi.z.zhang@intel.com \
--to=qi.z.zhang@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).