From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id E932D2C54
 for <dev@dpdk.org>; Fri, 23 Nov 2018 16:24:43 +0100 (CET)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 23 Nov 2018 07:24:42 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,270,1539673200"; d="scan'208";a="107107321"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107])
 by fmsmga002.fm.intel.com with SMTP; 23 Nov 2018 07:24:39 -0800
Received: by  (sSMTP sendmail emulation); Fri, 23 Nov 2018 15:24:39 +0000
Date: Fri, 23 Nov 2018 15:24:38 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>
Cc: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Trahe, Fiona" <fiona.trahe@intel.com>,
 "Shally.Verma@cavium.com" <Shally.Verma@cavium.com>,
 "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Message-ID: <20181123152438.GA14972@bricha3-MOBL.ger.corp.intel.com>
References: <1542978409-28668-1-git-send-email-tomaszx.jozwiak@intel.com>
 <1542983269-30093-1-git-send-email-tomaszx.jozwiak@intel.com>
 <1542983269-30093-2-git-send-email-tomaszx.jozwiak@intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1B41@BGSMSX101.gar.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1B41@BGSMSX101.gar.corp.intel.com>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Nov 2018 15:24:44 -0000

On Fri, Nov 23, 2018 at 03:10:51PM +0000, Varghese, Vipin wrote:
> <snipped>
> 
> > +#define MAX_DRIVER_NAME		64
> > +#define MAX_INPUT_FILE_NAME	64
> 
> <snipped>
> 
> > +comp_perf_options_check(struct comp_test_data *test_data) {
> > +	if (strcmp(test_data->driver_name, "") == 0) {
> 
> Should we use strncmp for boundary?
> 
Shouldn't be necessary here, but a better check might be just to check if
test_data->driver_name[0] == '\0'. No need to use a string function for
checking for an empty string.

/Bruce