From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by dpdk.org (Postfix) with ESMTP id BD6571B43F for ; Tue, 27 Nov 2018 23:24:18 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id y126so1208609pfb.4 for ; Tue, 27 Nov 2018 14:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iQxmqq1nNwXApQxS2ebC4dvmxxUvWHGs8N2jqkujuNY=; b=KhUzajB7BzVuX09NF5zSTd4fAWynwESHCDYVnCKbN2rbA+JheLouD6kPuIY7fua7yi g7UqdnCBYOywT0u8HK+xGxO4Rlx+jXiYlon4Cx6TYeTHh//afS8LiDW8l61aWg83fKOq ZYggZnD8QDVIu/VgKNrSOcxeD+puzHsx31dZR7IjhEi8AYiuEBYR0upWDeyU4+1FQqQL sZRzzebDyh+moUxnTJBZxWhuLq0ZtuK5HA07R5WV40cdhggLh1ucEAGiK8CvwrGn+pDZ eWkDZ+tpdmi7C12hBjt0hmgjjZfePC6Iw61i+kUozqYaDY83xdtryR3v7jbX9+/x72ds hQqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iQxmqq1nNwXApQxS2ebC4dvmxxUvWHGs8N2jqkujuNY=; b=lKI3zzhznUDfyWdzDCAj7Ixk1CW0S7ESmN4q5wICDvt75f6uMSw1nkJTlt+3lMmpeV 66zwoQS/pAwAy6CE4kj5YiTqQ0A95xkiwLYO5laQ2MO7cEWW6H2UGl6IBdDy/u7CN0jH Q9XWjakOR7DUcyYtArivRhUw5U1VofxH+jvSudiW7UB7fCad6OOiIO1I8EIRhBIjmmII ZYSxsnSFS/kkN3zuMb5eJE9p54EIsgqCds7NWQSA0WkgQFDnPlajk6gVh7FfsCXM7qgK khbbiYl3Ez6zRc4SLblkJZbJozwtfGMk13lakq7pOewNIUAO+T5C8gphJMZaD3vAicGM cBSw== X-Gm-Message-State: AA+aEWbmyk/GzsVNRIcMiL6CWy3sTVT9IOZNG3pKkrR+Cvbob37P0PTg 1y2vKvnhc7lCXRSr86p43LO+8LNhudM= X-Google-Smtp-Source: AFSGD/Vxbob0wK6cmVI7rYAuNEoIYUYSUTKjI9D7fcQxa3/GxeYpPAa7yXobXdqbQWxQecGWUiWNSw== X-Received: by 2002:a63:c846:: with SMTP id l6mr30625018pgi.78.1543357457598; Tue, 27 Nov 2018 14:24:17 -0800 (PST) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j6sm12482768pfg.126.2018.11.27.14.24.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Nov 2018 14:24:17 -0800 (PST) Date: Tue, 27 Nov 2018 14:24:15 -0800 From: Stephen Hemminger To: Honnappa Nagarahalli Cc: dev@dpdk.org, nd@arm.com, dharmik.thakkar@arm.com, malvika.gupta@arm.com, gavin.hu@arm.com Message-ID: <20181127142415.7950ad77@xeon-e3> In-Reply-To: <20181122033055.3431-2-honnappa.nagarahalli@arm.com> References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20181122033055.3431-2-honnappa.nagarahalli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 1/3] log: add TQS log type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 22:24:19 -0000 On Wed, 21 Nov 2018 21:30:53 -0600 Honnappa Nagarahalli wrote: > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Steve Capper > Reviewed-by: Gavin Hu > --- > lib/librte_eal/common/include/rte_log.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h > index 2f789cb90..b4e91a4a5 100644 > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > @@ -61,6 +61,7 @@ extern struct rte_logs rte_logs; > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ > #define RTE_LOGTYPE_GSO 20 /**< Log related to GSO. */ > +#define RTE_LOGTYPE_TQS 21 /**< Log related to Thread Quiescent State. */ > > /* these log types can be used in an application */ > #define RTE_LOGTYPE_USER1 24 /**< User-defined log type 1. */ Sorry, I don't think this is the right way now. All new logging should be using dynamic log types. We should work on getting rid of others (EFD, EVENTDEV, GSO).