From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-eopbgr740040.outbound.protection.outlook.com [40.107.74.40]) by dpdk.org (Postfix) with ESMTP id 212801B54B for ; Fri, 30 Nov 2018 08:26:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mSeQ+7KePAUfk19yrhd/y2UgrclzQQbMvrwYyNQOJF4=; b=f9M29zNx41qNlSNwNX6JgVRXVeavsXdDIchit79ml4UoxKVVriVbPSNUT+5IA+0G4RF2Xq+zLhzp6voF39N6ATo/1Sw8aK2pvETvVAWoF2Jl/qMtO5HYeU3KcBOPxrnzHKxcAxBQsOvwyqMcHJ2AaWGBlpLpPrKr3ZYsVAiPRIs= Received: from BYAPR07MB4966.namprd07.prod.outlook.com (52.135.238.207) by BYAPR07MB4837.namprd07.prod.outlook.com (52.135.203.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1382.18; Fri, 30 Nov 2018 07:26:29 +0000 Received: from BYAPR07MB4966.namprd07.prod.outlook.com ([fe80::8173:6c30:9144:add]) by BYAPR07MB4966.namprd07.prod.outlook.com ([fe80::8173:6c30:9144:add%2]) with mapi id 15.20.1361.019; Fri, 30 Nov 2018 07:26:29 +0000 From: Pavan Nikhilesh To: Erik Gabriel Carrillo , "Jacob, Jerin" , "rsanford@akamai.com" CC: "stephen@networkplumber.org" , "dev@dpdk.org" Thread-Topic: [PATCH 0/3] new software event timer adapter Thread-Index: AQHUiDwwB3trORY3wEWdl1toKPn0bKVn63eA Date: Fri, 30 Nov 2018 07:26:28 +0000 Message-ID: <20181130072610.GA26551@ltp-pvn> References: <1543534514-183766-1-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: <1543534514-183766-1-git-send-email-erik.g.carrillo@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR0101CA0043.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::29) To BYAPR07MB4966.namprd07.prod.outlook.com (2603:10b6:a03:5b::15) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [111.93.218.67] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB4837; 6:MzJEn/yWL3n0DL0gQLlJ9WyicYlOYERZ/HksrxssPLehWAYurhaD2PD1oJB/EZol9ufJf2BZXNaU6fzIRf5plXhwlGAdy72+NRqLeefItD8O1LFo92BGIhG++66ch7qJOEuxMXlb/tSOq1DEtSm2yRBUkwIbsM1TWlCTGjijVZ9OH2k7Ta2iyYS/qSAOsLXZDxwVkGRl45H9zajBkrub13770V7GyhvNDraw0uou5s9uWLOqNFiqtt70IoICPGGrwdAMZCJGjLK8TSVwo5Yy5QEqCf1aXNpoZNtCC3Hi2mHngmrubJqF5nwtIPu64d3SVitDjH1i/qqYNRKO2qG3baaWsk3t8wFHMHlWoupprGDBf1EhfUpY3LVhDbX38kbnctEnmVA99ondDhs/xVdhI3J4/n/DHCs+/B3a4jy1nfptFL3jBUNvO8TJ6z5/dOsvlEA8F/RWfN3n1CSdOD02WA==; 5:PYlA+yO2KQv5HL2RmDtZ0HatVvukcKIig+ON2i1OEjG+WMNpk3c5cL60H9dDwkgy+JJjhiC1bvYwdMAPfX1HaweVUMBOuhDFRo1rRdeCulyVHqYciC7AjVxwO1y5q1l7SgqAinZgQsV6aCFcKW6VVn3gYfoLhX1F84dDK00Epe0=; 7:XFAbSk2VjRlotpwCLzOYp9ektx/a14Naxmd3zcWLZzsDJynYaUugyEKzr3PiJbG+QQVFPeMLQWqfyI8tbPDGVh/wje4eknn/wz9cCTtyaQHa6BZzv+YV5k3feFprYcr6oOws5hujENR1Tbryto4HjA== x-ms-office365-filtering-correlation-id: 66fcd9c3-54c8-463a-f006-08d6569524be x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4837; x-ms-traffictypediagnostic: BYAPR07MB4837: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231453)(999002)(944501463)(52105112)(93006095)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB4837; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4837; x-forefront-prvs: 087223B4DA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(396003)(376002)(39860400002)(136003)(346002)(366004)(199004)(189003)(14454004)(6512007)(478600001)(5660300001)(72206003)(9686003)(97736004)(966005)(71190400001)(71200400001)(14444005)(6306002)(26005)(66066001)(76176011)(256004)(33656002)(8676002)(81156014)(81166006)(33716001)(2906002)(305945005)(6116002)(33896004)(78486014)(42882007)(99286004)(1076002)(186003)(6506007)(386003)(102836004)(3846002)(52116002)(68736007)(8936002)(6436002)(2501003)(11346002)(106356001)(105586002)(446003)(476003)(7736002)(229853002)(110136005)(53936002)(316002)(25786009)(6246003)(486006)(54906003)(6486002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4837; H:BYAPR07MB4966.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: X9cdjJOLA0ipzUXzyuMi4kNrdNmrRHl6uWNnHKbPP/Lir0b3dj5YeL+uqlm+JK1YvbYvPySJfaVV1wU/WX7MC/ZJvlzv7u3nsvhVXtb8P50wFQg6b8RhJIlCqu110NzVlupFHnvricpDoTj/5sFYZDjQb216FmZUtbqXxW03BSJeJJrv22ZMEZ/ev0uleaBI3B7jFm63MYJE/A2D42cQH/F+Cxxhnbn2kG1iukES1VbBkl+aoUHPpSGIgi8VsYDvX7IacfCK8s06za4R9fj/TzgGPan6LMkUZL0WZybrC4g6PT+c5uCvTrrKHBRY+zB0FCeynZZc6CiYdohLjeG5FwVRI+wd7+Nf/PovFDn3v3I= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <71CA6AF1841B844F8A6CBD86539BF80B@namprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66fcd9c3-54c8-463a-f006-08d6569524be X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2018 07:26:28.9545 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4837 Subject: Re: [dpdk-dev] [PATCH 0/3] new software event timer adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 07:26:31 -0000 Hi Eric, I think we may need to address the librte_timer and event_timer patches in separate series as we are modifying common code for the sake of sw_event_ti= mer PMD and the series title implies that only the PMD has been modified. Also, I think we need to profile and report the performance regression (timer_perf_autotest,) if any of the rte_timer library with the new patches as it is also used as a standalone library. On Thu, Nov 29, 2018 at 05:35:11PM -0600, Erik Gabriel Carrillo wrote: > This patch series introduces a new version of the event timer > adapter software PMD [1]. In the original design, timer event producer > lcores in the primary and secondary processes enqueued event timers > into a ring, and a service core in the primary process dequeued them > and processed them further. To improve performance, this version does > away with the ring and lets the lcores in both primary and secondary > processes insert timers into directly into the timer skiplist data > structures; the service core directly accesses the lists as well. > To achieve this, however, modifications to the timer library [2] are > required to enable the timer skiplists to be created and accessed in > shared memory. New APIs are introduced in the timer library to enable > selecting from multiple instances of the timer skiplists. Instances of > the event timer adapter, as well as the original APIs of the timer > library, can then each access distinct timer lists. > > Future versions of this series will hopefully improve the names > used for the data structures and APIs in the timer library. > > This series depends on the following patch: > https://patches.dpdk.org/patch/48417/ > > [1] https://doc.dpdk.org/guides/prog_guide/event_timer_adapter.html > [2] https://doc.dpdk.org/guides/prog_guide/timer_lib.html > > Erik Gabriel Carrillo (3): > timer: allow timer management in shared memory > timer: add function to stop all timers in a list > eventdev: add new software event timer adapter > > lib/librte_eventdev/rte_event_timer_adapter.c | 687 +++++++++++---------= ------ > lib/librte_timer/Makefile | 1 + > lib/librte_timer/rte_timer.c | 579 ++++++++++++++++++--= -- > lib/librte_timer/rte_timer.h | 200 +++++++- > lib/librte_timer/rte_timer_version.map | 22 +- > 5 files changed, 972 insertions(+), 517 deletions(-) > > -- > 2.6.4 >