From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id B59111B5CA for ; Sat, 1 Dec 2018 00:38:18 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id n2so3152995pgm.3 for ; Fri, 30 Nov 2018 15:38:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p5c8W/F1ONMqfQCGS+/QozcQh6O5OK2l+FxCt6KksBc=; b=LRjPOWpMRG/wXhHiU4IRvE1LVOzW51GFSZnNB9DJ2BBG1jBYPHLNOcdZAa17xugS7E hQcatjUae0gIMdgWeY7pMDlRQchP3vHpAxQgjZY06Aax0gvSyM488w1RzqGPWItdG5mU PdPH+lJcKyyQg5uBKZvjxDLxeRXm7PXpBd8FMVr4XM+8OrVowKGaQ7jjiGSzcdd823On auTxDSm2zFCA2QDl8/hpfR7qWkJR2tJfkr9re4BYwpGFDynxUCOvrbG0mskp+19XGKOo A/vylOgNDxySm/IM4V6gHihqmohfPPTWn+bE+tebL4irSH42rAu5aQANyv+lH404+3tg DOSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p5c8W/F1ONMqfQCGS+/QozcQh6O5OK2l+FxCt6KksBc=; b=NIBSS4O2Ycm5PcP6uRKi9eoEADcxgvg1aKISUkygvjO16mM5Ef57NnPAm2kGaxeNVr 5N9X9bon45pirTQES/r6PVNfDs8pbeCJVHLBH2HCs2CYvcUkrbbmCKAdZ4/+S4eMjFS7 AQa7mKqEIoQwtl67+drU5Gf1CwzZOa9ADwAy4/BlGSij76TryDhawHsgDrMA4njTV7xc CbOk4LNBBhxyRtN8qJ80kaZjVU33I1RgzFw6s95HqhNH+jwLxGMJWkwWVkQv/96znRsz +C/8A4Y0alaFZzbFqyg5dcCFmj56CMuL+Ol0aFHuja7LZ9hcfCsrNYwaGVSsVBqX4tVE Qeng== X-Gm-Message-State: AA+aEWYZ7tPlFFAyHFwd/R11Tt+WBSs9UI4ibchoTKePjMGRp96u8fRd dTMM+v0jlqS/Wn70uwdVe0r0/39tgzg= X-Google-Smtp-Source: AFSGD/VzlT+7hndatAQiZNL/+ZE7Gj7lb8bNJdHduoZJI/uc6aj1KbkLTurRElApcqAWoJbB/iXVXw== X-Received: by 2002:a65:6645:: with SMTP id z5mr6496311pgv.351.1543621097566; Fri, 30 Nov 2018 15:38:17 -0800 (PST) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d80sm19874463pfm.146.2018.11.30.15.38.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Nov 2018 15:38:17 -0800 (PST) Date: Fri, 30 Nov 2018 15:38:15 -0800 From: Stephen Hemminger To: Igor Ryzhov Cc: dev@dpdk.org Message-ID: <20181130153815.3be2f30b@xeon-e3> In-Reply-To: <20181130194750.13870-1-iryzhov@nfware.com> References: <20181130192946.13732-1-iryzhov@nfware.com> <20181130194750.13870-1-iryzhov@nfware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 23:38:19 -0000 On Fri, 30 Nov 2018 22:47:50 +0300 Igor Ryzhov wrote: > Current implementation of kni_ethtool_ops just uses corresponding > ethtool_ops function of underlying driver for all functions except for > .get_link. This commit sets kni->net_dev->ethtool_ops directly to the > ethtool_ops of the corresponding driver. > > For unknown drivers (all but ixgbe and i40e) we still use > kni_ethtool_ops with implemented .get_link function. > > Signed-off-by: Igor Ryzhov Why does KNI still support ethtool which: 1. Only works on a subset of devices 2. Requires a 3rd implmentation of the HW device (Linux, DPDK, and KNI) Then again why does KNI exist at all? What is missing from virtio user which is faster anyway.