From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15B22A0519; Fri, 3 Jul 2020 17:27:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE6041DC2A; Fri, 3 Jul 2020 17:27:23 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id DB1481DBC4 for ; Fri, 3 Jul 2020 17:27:21 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 3D5DA5803A5; Fri, 3 Jul 2020 11:27:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 03 Jul 2020 11:27:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= WbgDp1a/BXC862fnP6CntZS9s9lpXuaM5Hvx+J6RHFo=; b=NE615WKiE6TNJ5S9 CVnpyPcl8VKxWDgdwoZfSQQugapFVwfWOd5+poNQ/9BWHaYbxJy3iIxhu/+Da9FW CMEEJMxFkIytUGqoJ/iHSMYUjPMttSdTKy68QPSI8xviySdjA02oQyMqfkgECG5j k3rBPsaslr25WxZb2L0FwvDCbOT4ALjLK7+ZSarGGN48kM0quFrMIIFWqtTFp+Qm j7Q9g/DqHlDJQ2DEnC2kVFhtwqF1Ik+jbft1uOcHT4t7HBovWouP9i5SixB9KheM Sn0aSowziEGnItVwvh+Au3RS4E52+pb1854SUGPxFL2ntNqHXUfAlYOhesNWEUmk SVQX3w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=WbgDp1a/BXC862fnP6CntZS9s9lpXuaM5Hvx+J6RH Fo=; b=FiWrmeSK7HFN2P8uaDs6eYpef8BTwKlv4Hhqq1YD6SQacscaAek5IUF8T 6lplavzCx5LnJqIAD8+B0Z31HH525xCb9yCTpYvIVSStZH0pTH6tlfE8CCAd4wPM FPSk07avHdPTlNyYfg4Hoe7jOXStNGyMrrSfknwPiZVY/zGwbEHbj/kruNWqncxl PoMLkdmVCUsGovf3QSfa9NJrspYQP82kifHB16ZnyRb7dzgEZI4uEjvU6a7hukFv dWbMmBSEscRtlpFNOCm2/LOJE3znojozvKMWctqx6Gcy+1tmBomgDSEe77S/kNYL TMYU1YfCxQ9AZdDvRgEbSGDDl/FQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrtdeigdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpefgvddutdfgieffkeejueeltefhfeefudffveeluefhtdffvdeuhfef ledvteejgfenucffohhmrghinhepghgvthdqmhgrihhnthgrihhnvghrrdhshhenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5F22F328006C; Fri, 3 Jul 2020 11:27:19 -0400 (EDT) From: Thomas Monjalon To: Matan Azrad , Jerin Jacob , "Jiawei(Jonny) Wang" Cc: Ori Kam , Slava Ovsiienko , dpdk-dev , Raslan Darawsheh , "ian.stokes@intel.com" , "fbl@redhat.com" , ferruh.yigit@intel.com, arybchenko@solarflare.com Date: Fri, 03 Jul 2020 17:27:18 +0200 Message-ID: <2018114.U5Vea0xDAA@thomas> In-Reply-To: References: <1593102379-400132-1-git-send-email-jiaweiw@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/07/2020 17:08, Jerin Jacob: > On Fri, Jul 3, 2020 at 8:25 PM Matan Azrad wrote: > > From: Jerin Jacob: > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > library(ethdev). > > > Please depreciate the old API. > > > We should not have two separate paths for the same function in the same > > > ethdev library. It is pain for app and driver developers. > > > > What are about all the other rte_flow parallel configuration APIs in ethdev: > > promiscuous_enable; > > promiscuous_disable; > > allmulticast_enable; > > allmulticast_disable; > > mac_addr_remove; > > mac_addr_add; > > mac_addr_set; > > set_mc_addr_list; > > vlan_filter_set; > > vlan_tpid_set; > > vlan_strip_queue_set; > > vlan_offload_set; > > vlan_pvid_set; > > udp_tunnel_port_add; > > udp_tunnel_port_del; > > ... > > > > These APIs can be replaced easily by rte_flow API. > > Do you think we need to deprecate all? > > I think, basic stuff like below can have separate API. > 1) promiscuous_enable; > 2) promiscuous_disable; > 3) allmulticast_enable; > 4) allmulticast_disable; > 5) mac_addr_remove; > 6) mac_addr_add; > 7) mac_addr_set; > 8) set_mc_addr_list; "Basic" is not a precise definition :) I would say port-level configuration should remain out of rte_flow API. > But The VLAN and UDP related should be rte_flow candidates.(IMO) Yes definitely, tunneling is better managed with rte_flow. This is an important discussion, I Cc other ethdev maintainers. Note: this is an ethdev patch, all ethdev maintainers should be Cc'ed. Aren't you using --cc-cmd devtools/get-maintainer.sh ?