From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 222591B525 for ; Sat, 1 Dec 2018 18:31:53 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id z9so4357109pfi.2 for ; Sat, 01 Dec 2018 09:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LMdBgh15AX2pfxdYrEC+EWqsKthn4kuEIGMdeGSbthg=; b=q8wyVhW1T1+M2gtoHmrQ471JGWuH292LvfPEsmF26lyzNljx3PlvZB22Hsc81PKi8M 4peSXZem++hX3pp+PiwKBFko/nBhORRClC+tllKujxwPQ2xuNr2Q9lRxWx/VBC12a7jZ nroNSY/vYuygvxw26OqKQ1KiQ+booJWyJSmGgzq2gD0Omav1bNf+QmaC8zjdS6BLnm04 YMUyDRmQmCNn94VYAMkgqaAdX2HkIh2nPech1jQmHjFBKjnpn+oBnFUMafHdfgQYV488 7z+XdPLsAMcitmry5ojHhLInm2pCmjDiKHl2axUNwcChBda97A3aE6qjikVB3Q9K4HNW eb9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LMdBgh15AX2pfxdYrEC+EWqsKthn4kuEIGMdeGSbthg=; b=Oonpw3r0EnEplPZsdFlsG6D+5OWOdx4QqEBJggtuKTaveFP1E21htDobUue9TES6Ym yvjJqOYOABjqH64kgpfZqTIrVwCIAJGt1Jo4pHO1vCpVE6B8VRA5NeHqY+qIjwQ8aQTy Ef+ZcELij+TaOIUMfdOfPC4w/EWvF3T6dw/skXpjKN9HlqyBkx6QAnNEjBsqhqcQywbL izZeGN1v+J7/qb7By5B+FySwcZXIoeaRtZDmk3S55DjP0J4T4Ww3ivY7x88RWSg5hNJs pqRyT5AQoXzlvWXxcgPQLui8RKESoW+ultvyvZ8JgPN1uGk6eYStrlWUDk/3gok6k7ML Jl7A== X-Gm-Message-State: AA+aEWa7vzfoafAlbEMaL7DO3xtqKp4PyqdyJG62z8ADapaosAENChgt 9iBUoOJ/omIL0B+P3uugxPAn8g== X-Google-Smtp-Source: AFSGD/XkTenH9tTMYf9dUZqNXWuBm0dK0Y97u4vmc/ANKLvAEe5cCviyOaQq1AYGzZGhKHvEpirQOQ== X-Received: by 2002:a62:26c7:: with SMTP id m190mr10142434pfm.79.1543685511999; Sat, 01 Dec 2018 09:31:51 -0800 (PST) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n23-v6sm19681280pfg.84.2018.12.01.09.31.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Dec 2018 09:31:51 -0800 (PST) Date: Sat, 1 Dec 2018 09:31:50 -0800 From: Stephen Hemminger To: Igor Ryzhov Cc: dev@dpdk.org Message-ID: <20181201093150.2ab26e85@xeon-e3> In-Reply-To: References: <20181130192946.13732-1-iryzhov@nfware.com> <20181130194750.13870-1-iryzhov@nfware.com> <20181130153815.3be2f30b@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2018 17:31:53 -0000 On Sat, 1 Dec 2018 14:12:54 +0300 Igor Ryzhov wrote: > Hi Stephen, >=20 > I also do not see the point of the current implementation of ethtool > support. > That's why I sent this patch =E2=80=93 it enables ethtool_ops for all dev= ices, > independent of the underlying driver. > Right now only .get_link is supported, but I am thinking about > implementation of a larger set of functions, using req/resp queue, like > netdev_ops functions are working. >=20 > Regarding the KNI itself, we use it as Linux mirror of physical port for: > 1. Port configuration from Linux =E2=80=93 such functions as set_mac, cha= nge_mtu, > etc. And ethtool_ops will be used the same way. > 2. Passing control-plane packets to Linux. >=20 > Can virtio user be used the same way, as a mirror of physical port? >=20 > Best regards, > Igor In Linux if device does not supply get_link the base code does the right thing u32 ethtool_op_get_link(struct net_device *dev) { return netif_carrier_ok(dev) ? 1 : 0; } Doing set_mac, change_mtu and ethtool_ops in virtio_user should be possible but probably not implemented.