From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 393C71B3F0 for ; Mon, 3 Dec 2018 20:51:25 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id t13so6174127pgr.11 for ; Mon, 03 Dec 2018 11:51:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7d8nF6v2cqTZefWghvw4GuqUYh+0zBd8mpHA7CAV0zs=; b=Ln7g7uHDUJfocZPJNdguiut3Btc8wPYGJkRWnPprQLPlQlI1PKGKl4WZeZlJiDmgQP pDlWyn0fSo9AJfTRiK1R2DNQUmWWKqCsMb7O2U67gJ3utKPY2e0l2+gKRfBXGYc5pY5u GUhzBAGhrgy6Ato+vMZ7K4+vHIeml8lXcb2iB0aUW/xz/P1wGH40tMMJrsXKx6jAoNt9 Ly5rSJ9ptmRXbW6FER5sUz3MeY4xRiBRr1PcbS4ED+oG3Lz5TQPsRi+M8bQ+wt5QpI63 mp/eHNc4t0JsB0AKUVBfn0CF+Cqqk/UqB/gDKVbiih5SynvzaWBsIAqJdcSf1vm4FlMS 7kPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7d8nF6v2cqTZefWghvw4GuqUYh+0zBd8mpHA7CAV0zs=; b=txP8oxsHgA59hIbi0nA7RelEq/urQQ6COHPngX2nyaDyzNXTcXm/AmU68HkKX6tVlE bxP6k2gxNS6f5wWnH6SXaOXb8KG9a/B4vArX47AKQVf7TkX9MM8sdzF+Uyp6l7HZl51s 7xyZBfnrpNuuhjVDsI7p0dME2IPPNKnjHaxAAbqOYHrLLWBXsDP9yOZR7Qh2cvk4vKHY +6gX+QZT3Mmw1CwYBq0Trcty4KplocFcdDOi948DN4qixNpFK74SUxzxld+KR3agq8pm NNT6E4W5x8huzKJMqDVAk5duPvRpeUchzAayREz80Ii8XmH7XHNNlcJ+O39d9buTfStE Symg== X-Gm-Message-State: AA+aEWZ3q/Cea3FKYkOrA0wNTYHGkENFborfyW9BU8eUb0fyI2RZClkt FkVflNzp62E7VYG4kULgfQqM6A== X-Google-Smtp-Source: AFSGD/Uq59n6LcrXPQKpACLnJ9Di5gWUGwB4p5t9q+siHhcHjDTmLQrcsgg6uo1JblxjTccJkOBWUA== X-Received: by 2002:a62:5658:: with SMTP id k85mr17052618pfb.231.1543866684162; Mon, 03 Dec 2018 11:51:24 -0800 (PST) Received: from shemminger-XPS-13-9360 ([64.124.208.80]) by smtp.gmail.com with ESMTPSA id f67sm20357918pfc.141.2018.12.03.11.51.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Dec 2018 11:51:24 -0800 (PST) Date: Mon, 3 Dec 2018 11:51:19 -0800 From: Stephen Hemminger To: Igor Ryzhov Cc: dev@dpdk.org Message-ID: <20181203115119.05ffa05f@shemminger-XPS-13-9360> In-Reply-To: References: <20181130192946.13732-1-iryzhov@nfware.com> <20181130194750.13870-1-iryzhov@nfware.com> <20181130153815.3be2f30b@xeon-e3> <20181201093150.2ab26e85@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2018 19:51:25 -0000 On Sun, 2 Dec 2018 13:54:11 +0300 Igor Ryzhov wrote: > Stephen, > > ethtool_get_link returns EOPNOTSUPP if device doesn't supply get_link: > You are right, kni needs to supply ethool ops and can use the standard ethtool_op_get_link as the callback.