From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id D0CE12BF7
 for <dev@dpdk.org>; Thu,  6 Dec 2018 13:19:35 +0100 (CET)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id wB6CJXv0012624;
 Thu, 6 Dec 2018 04:19:34 -0800
Date: Thu, 6 Dec 2018 17:48:10 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Dekel Peled <dekelp@mellanox.com>
Cc: "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
 "jingjing.wu@intel.com" <jingjing.wu@intel.com>,
 "bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "orika@mellanox.com" <orika@mellanox.com>,
 "shahafs@mellanox.com" <shahafs@mellanox.com>
Message-ID: <20181206121808.GA16386@chelsio.com>
References: <1544097974-5507-1-git-send-email-dekelp@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1544097974-5507-1-git-send-email-dekelp@mellanox.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from
	testpmd doc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2018 12:19:36 -0000

On Thursday, December 12/06/18, 2018 at 17:36:14 +0530, Dekel Peled wrote:
> testpmd actions set_tp_src and set_tp_dst documentation adds the
> of_ prefix to action names, while the implementation doesn't add it.
> 
> This patch removes the prefix from action names in testpmd
> documentation.
> 
> Fixes: 9ccc94919500 ("ethdev: add flow API actions to modify TCP/UDP port numbers")
> Cc: rahul.lakkireddy@chelsio.com
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 056f8bb..9d4f107 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -3931,12 +3931,12 @@ This section lists supported actions and their attributes, if any.
>  
>    - ``ipv6_addr``: New IPv6 destination address.
>  
> -- ``of_set_tp_src``: Set a new source port number in the outermost TCP/UDP
> +- ``set_tp_src``: Set a new source port number in the outermost TCP/UDP
>    header.
>  
>    - ``port``: New TCP/UDP source port number.
>  
> -- ``of_set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
> +- ``set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
>    header.
>  
>    - ``port``: New TCP/UDP destination port number.
> -- 
> 1.8.3.1
> 

Good catch!

Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>