From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 4F07F1B113 for ; Mon, 10 Dec 2018 16:57:14 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id u18so5430679plq.7 for ; Mon, 10 Dec 2018 07:57:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s5mpz7Z/zywtglSVqAIk5VSWchWn/YhGJAEdeAats4s=; b=FC/vgSPJv86Bi+BqUsoXXHhsOmAOi9yq8WAvXPQ3hZ0ZDCv9aLcsk/Qwxw7a4K9wsB Zz/XKynZJ/jTQ4cPG5CEJyoCVsHRbU+gRUxRrkxXupen748bhBOpvCfyFjTn2oc77sGK 7ZGWfwVnKnu2AtyNK2fX5m/hmcNOiy8Hij1x6lJdQTWebhMQIRLklY802g0LUxaLOOSX TTfIDdJC8RoDbtArgok/TolHvnQNEce2zUOS7oOcgQFgNaO8t8rNOGvhayDTT7QTdtNr 2ub4XU5Ex3d+6aSZ7x0Hncz+Z6+pqwE1BAb+7UOB9h7bjgsjAJ4Rfet9Fx2ey5LUkhgk ADGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s5mpz7Z/zywtglSVqAIk5VSWchWn/YhGJAEdeAats4s=; b=p/giR29ySm6tKcJ7WFQVYegf597Nqd4Eh+TY/l0zCB2EQrSH/Rgi7m7ev820aT8m37 A+G71IuXoOcEF9eqVNoJsznJDhfXdQllkLTsjx7C2/CD7oCZYdAA2E7UQJELR1XvX827 stSg4fYxSUnLGSpsNz8r/nS5rH4SPmfEx746OqtCnDaqO0qLuMHUJ/nsc4i7N45IQcw9 gVTWTX/JVKn5Ysa6PrpWCfz39a4GNagwH9ZTUC2hHTZAitPIPAXgqgu9nAAb8ZgKZQUN coSmJnUpcHpzGDkyRgUlVZ8sYDF3rMlX5DGnbtLPZqlgXpzOYS8PlL0UtnpvL/I6C945 eo/Q== X-Gm-Message-State: AA+aEWYBrtZv3An6IQ99fCRbY0akg0/TIZcxmc9Zx6lxhrv1/0BKsxjO w1HsjHs0XaU5JwV5RPB8OQMIRQ== X-Google-Smtp-Source: AFSGD/WCi1urNlsDPBUJA4/hqPPfou3wg8gYm53NgM0TTaf5BNmdxUp9wNZ9Yj3g6jyCK7JzHL9mMA== X-Received: by 2002:a17:902:29ab:: with SMTP id h40mr12507747plb.238.1544457433424; Mon, 10 Dec 2018 07:57:13 -0800 (PST) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l185sm18045936pfl.54.2018.12.10.07.57.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Dec 2018 07:57:13 -0800 (PST) Date: Mon, 10 Dec 2018 07:57:11 -0800 From: Stephen Hemminger To: Nikhil Rao Cc: cristian.dumitrescu@intel.com, jasvinder.singh@intel.com, dev@dpdk.org Message-ID: <20181210075711.1befe533@xeon-e3> In-Reply-To: <1543470882-145287-1-git-send-email-nikhil.rao@intel.com> References: <1543470882-145287-1-git-send-email-nikhil.rao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue weight X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 15:57:14 -0000 On Thu, 29 Nov 2018 11:24:42 +0530 Nikhil Rao wrote: > > + /** Double precision RED queue weight support. When non-zero, this > + * this parameter indicates that RED queue weight in double precision > + * format is supported. > + * @see struct rte_tm_red_params::wq_is_log2 > + * @see struct rte_tm_red_params::wq_dp > + */ > + int cman_wred_wq_dp_supported; > + > + /** Negated log2 RED queue weight support. When non-zero, this > + * parameter indicates that RED queue weight in negated log2 format > + * is supported. > + * @see struct rte_tm_red_params::wq_is_log2 > + * @see struct rte_tm_red_params::wq_log2 > + */ > + int cman_wred_wq_log2_supported; > + One suggestion: Since these are flag values use u8. Takes less space. And maybe use pahole utility to find existing hole to put them in.