From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 371161B128; Wed, 12 Dec 2018 07:17:12 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2018 22:17:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,343,1539673200"; d="scan'208";a="106771966" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.193]) by fmsmga007.fm.intel.com with ESMTP; 11 Dec 2018 22:17:09 -0800 Date: Wed, 12 Dec 2018 14:17:02 +0800 From: Ye Xiaolong To: Didier Pallard , Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org, Qi Zhang , Beilei Xing Message-ID: <20181212061702.GA101858@intel.com> References: <20181211172501.31467-1-didier.pallard@6wind.com> <38c25e0c-1c7f-389c-16bd-14cd56789bae@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38c25e0c-1c7f-389c-16bd-14cd56789bae@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: revert fix offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 06:17:12 -0000 On 12/11, Ferruh Yigit wrote: >On 12/11/2018 5:25 PM, Didier Pallard wrote: >> This reverts >> commit 09a62d75691f ("net/i40e: fix offload not supported mask") >> >> Contrary to what is said in above patch commit log, >> I40E_TX_OFFLOAD_NOTSUP_MASK is the mask of Tx offload bits that are part >> of PKT_TX_OFFLOAD_MASK but not included in I40E_TX_OFFLOAD_MASK. >> Above patch erroneously includes all PKT_RX_OFFLOAD_ bits in the >> I40E_TX_OFFLOAD_NOTSUP_MASK, this is not what is expected. > >Argh, yes it does set Rx offload bits, +1 to revert. >cc'ed author and maintainers of the PMD. > Thanks for catching it and sorry for my unthoughtful patch. Thanks, Xiaolong >> Restore the initial xor that gives the expected result. >> >> Fixes: 09a62d75691f ("net/i40e: fix offload not supported mask") >> Cc: stable@dpdk.org >> Signed-off-by: Didier Pallard >> --- >> drivers/net/i40e/i40e_rxtx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c >> index e1152ff0ea58..ab74a488f88b 100644 >> --- a/drivers/net/i40e/i40e_rxtx.c >> +++ b/drivers/net/i40e/i40e_rxtx.c >> @@ -69,7 +69,7 @@ >> I40E_TX_IEEE1588_TMST) >> >> #define I40E_TX_OFFLOAD_NOTSUP_MASK \ >> - ~(PKT_TX_OFFLOAD_MASK & I40E_TX_OFFLOAD_MASK) >> + (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK) >> >> static inline void >> i40e_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile union i40e_rx_desc *rxdp) >> >