From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 640411B676 for ; Fri, 14 Dec 2018 17:28:47 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id c73so3056936pfe.13 for ; Fri, 14 Dec 2018 08:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/c8M07gLlgOEUBi2Xu86sFum4H3ogx6PhRRnOQ+8yM8=; b=kDwewdl+MeEL0nLJf00mT4A9FjYJPRz2Dkj0itWVQZ7ZTx/PQ9w+/nvBhbOIE7nu+j bXopUXIEn6ioliIai5IYtycQubIwqdd4OCGRvVajQSJA3qpV5T1iMG6TAL3vjQpMAtlO dcRd25m6xaODuHutpcd9t9HNi60vHQO2cQ6BwzvnTHc2TEIRfDXOPuYiWKwUXcnIac9C puS1792KMCzm/l+nvL4+A8xCwd+zctCvJsgOfwCeZjPUqv/7RJjxP2qZqE3Vexh/y+Bv grKRz6S/CWTRWl3VDKAQNdB7qpBpo0uq2kPqAVPtRjT3gkRRXNKuFzxBXQFbqwcp9bMQ ju0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/c8M07gLlgOEUBi2Xu86sFum4H3ogx6PhRRnOQ+8yM8=; b=Y37jy9wrOrWbGdsfSMJyYe/HFci4UBs2iOBAw4xNQrtsHle+0Hha0S35VIDhyw2fUb u5vnwGh/Jow2TOPPff6NDtuwUlBwxzqt9CrT/0SX3ICUgURMinmqdsUZmD4bpkZjqf29 w2hD++t+qu9yjoFJVpEuZ5mxyWp999UQl7KRotrXjuxwybXgxeFZUA0M/iFg8KhfDnDa CBBhrvMNHq91ap3T1LO6i8rbCwogXHJCNC5GNdAJGm/bhddg7ZoNvBJGJfPmdgtMhVTt doW0oMPDMCajDeTJ9hSpiXErcrucHvlt4lapeSxl6xh3r4A/pxTCR94Or1vSek15RGj+ bo8Q== X-Gm-Message-State: AA+aEWYuDkyt1gtQWMgBRlXCTWHirPPe6BHiNFSYlUbp9j7tEZPPaYcs iYWBFyHkGOgTFodFXhQ7Ma5sIg== X-Google-Smtp-Source: AFSGD/U+R/QvbExsuYKeQFHUXeGQZ3hOSJfsdaBjAPuU6WCD1anF9wy7n3xkeQzvnrKK2f2XgPEG/Q== X-Received: by 2002:a63:2784:: with SMTP id n126mr3388340pgn.48.1544804926375; Fri, 14 Dec 2018 08:28:46 -0800 (PST) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 125sm6954582pfg.39.2018.12.14.08.28.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Dec 2018 08:28:46 -0800 (PST) Date: Fri, 14 Dec 2018 08:28:44 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20181214082844.2b125896@xeon-e3> In-Reply-To: <52a74eca-3de8-c2bf-08ad-cf7602c63ffc@intel.com> References: <20181214012621.15213-1-stephen@networkplumber.org> <20181214012621.15213-2-stephen@networkplumber.org> <52a74eca-3de8-c2bf-08ad-cf7602c63ffc@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] net/netvsc: support receive without vlan strip X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 16:28:47 -0000 On Fri, 14 Dec 2018 16:09:33 +0000 Ferruh Yigit wrote: > On 12/14/2018 1:26 AM, Stephen Hemminger wrote: > > In some cases, VLAN stripping is not desireable. If necessary > > re-insert stripped vlan tag. > > > > Signed-off-by: Stephen Hemminger > > <...> > > > @@ -501,6 +501,14 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct hn_rx_bufinfo *rxb, > > if (info->vlan_info != HN_NDIS_VLAN_INFO_INVALID) { > > m->vlan_tci = info->vlan_info; > > m->ol_flags |= PKT_RX_VLAN_STRIPPED | PKT_RX_VLAN; > > + > > + /* NDIS always strips tag, put it back if necessary */ > > + if (!hv->vlan_strip && rte_vlan_insert(&m)) { > > Should 'PKT_RX_VLAN_STRIPPED' flag removed when vlan inserted back? This is already done by rte_vlan_insert()